New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report minfeefilter value in getpeerinfo rpc #13987

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
6 participants
@ajtowns
Copy link
Contributor

ajtowns commented Aug 16, 2018

Lowering the minimum relay fee is only useful when many nodes in the p2p network also lower the fee, so to make it easier to understand progress on that front, this includes the value of the minfeefilter in getpeerinfo, so you at least have visibility to what fees your neighbours are currently accepting.

@fanquake fanquake added the P2P label Aug 16, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Aug 16, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13152 ([rpc] Add getnodeaddresses RPC command by chris-belcher)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ajtowns ajtowns referenced this pull request Aug 16, 2018

Closed

Lower default relay fees #13922

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Aug 16, 2018

utACK 840aeb1

@promag
Copy link
Member

promag left a comment

utACK 840aeb1.

@@ -102,6 +102,7 @@ static UniValue getpeerinfo(const JSONRPCRequest& request)
" ...\n"
" ],\n"
" \"whitelisted\": true|false, (boolean) Whether the peer is whitelisted\n"
" \"minfee\": n, (numeric) The minimum fee rate for transactions this peer accepts\n"

This comment has been minimized.

@promag

promag Aug 17, 2018

Member

Could be minfeefilter to not clash with

" \"minfee\": xxxxx, (numeric) Minimum fee in the block\n"

This comment has been minimized.

@ajtowns

ajtowns Aug 27, 2018

Contributor

This is a good idea, done.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Aug 27, 2018

@ajtowns please respond to @promag's comment, if you don't want to make the change that's okay too, but merge is essentially blocked on your response

Report minfeefilter value in getpeerinfo rpc
Lowering the minimum relay fee is only useful when many nodes in the
p2p network also lower the fee, so to make it easier to understand
progress on that front, this includes the value of the minfeefilter in
getpeerinfo, so you at least have visibility to what fees your neighbours
are currently accepting.

@ajtowns ajtowns force-pushed the ajtowns:201808-peerinfo-minfee branch from 840aeb1 to 5778bf9 Aug 27, 2018

ken2812221 pushed a commit to ken2812221/bitcoin that referenced this pull request Aug 27, 2018

Merge bitcoin#13987: Report minfeefilter value in getpeerinfo rpc
5778bf9 Report minfeefilter value in getpeerinfo rpc (Anthony Towns)

Pull request description:

  Lowering the minimum relay fee is only useful when many nodes in the p2p network also lower the fee, so to make it easier to understand progress on that front, this includes the value of the minfeefilter in getpeerinfo, so you at least have visibility to what fees your neighbours are currently accepting.

Tree-SHA512: 059f01bf2a32c98fce1648a13b7898701203b354d0209ee34e6683994b720eb594cf24968e66b699caae5e17e53d351e73281f042dd094decde14d3a318e9fb3

@MarcoFalke MarcoFalke merged commit 5778bf9 into bitcoin:master Aug 27, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment