Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Remove dead code for nVersion=10300 #14025

Merged
merged 2 commits into from Aug 23, 2018

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Aug 22, 2018

This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

@MarcoFalke MarcoFalke added the P2P label Aug 22, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Aug 22, 2018

utACK fa5099c

scravy
scravy approved these changes Aug 22, 2018
Copy link
Contributor

@scravy scravy left a comment

<3

Copy link
Contributor

@domob1812 domob1812 left a comment

utACK fa5099c.

@Empact
Copy link
Member

@Empact Empact commented Aug 23, 2018

utACK fa5099c MIN_PEER_PROTO_VERSION is 31800

@fanquake
Copy link
Member

@fanquake fanquake commented Aug 23, 2018

utACK fa5099c
Looks like the final place in the code checking for that version is in walletdb:

if (wss.nFileVersion == 10300)

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Aug 23, 2018

utACK fa5099c

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Aug 23, 2018

utACK fa5099c

If you felt like it you could also remove a bunch of additional code from the msg_version class in test_framework/messages.py since the test framework won't work for anything older than a release or two ago. You could remove the if self.nVersion >= 106 and if self.nVersion >= 209: conditionals.

@MarcoFalke MarcoFalke force-pushed the Mf1808-netProc10300 branch from faf5d7e to fa74d3d Aug 23, 2018
@jnewbery
Copy link
Member

@jnewbery jnewbery commented Aug 23, 2018

utACK fa74d3d.

We could also assert that the version is greater than MIN_PEER_PROTO_VERSION in the desererialize method of msg_version, but maybe that's overkill.

@MarcoFalke MarcoFalke merged commit fa74d3d into bitcoin:master Aug 23, 2018
1 of 2 checks passed
MarcoFalke added a commit that referenced this issue Aug 23, 2018
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
@MarcoFalke MarcoFalke deleted the Mf1808-netProc10300 branch Aug 23, 2018
markblundeberg pushed a commit to markblundeberg/bitcoin-abc that referenced this issue Nov 19, 2019
Summary:
fa74d3d720 qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099ceb7 p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434

Backport of Core PR14025
bitcoin/bitcoin#14025

Also removed relevant obsolete code from seeder.

Reviewer note: the net_processing changes we made in D333

Test Plan:
  make check
  test_runner.py
  ./bitcoin-seeder

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4449
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Apr 16, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Apr 16, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Apr 19, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Apr 20, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue May 10, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue May 12, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 9, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 9, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 10, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 11, 2020
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants