Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Remove dead code for nVersion=10300 #14025

Merged
merged 2 commits into from Aug 23, 2018

Conversation

Projects
None yet
8 participants
@MarcoFalke
Copy link
Member

commented Aug 22, 2018

This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

@MarcoFalke MarcoFalke added the P2P label Aug 22, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

utACK fa5099c

@scravy

scravy approved these changes Aug 22, 2018

Copy link
Contributor

left a comment

<3

@domob1812
Copy link
Contributor

left a comment

utACK fa5099c.

@Empact

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

utACK fa5099c MIN_PEER_PROTO_VERSION is 31800

@fanquake

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

utACK fa5099c
Looks like the final place in the code checking for that version is in walletdb:

if (wss.nFileVersion == 10300)

@practicalswift

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

utACK fa5099c

@jnewbery

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

utACK fa5099c

If you felt like it you could also remove a bunch of additional code from the msg_version class in test_framework/messages.py since the test framework won't work for anything older than a release or two ago. You could remove the if self.nVersion >= 106 and if self.nVersion >= 209: conditionals.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1808-netProc10300 branch to fa74d3d Aug 23, 2018

@jnewbery

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

utACK fa74d3d.

We could also assert that the version is greater than MIN_PEER_PROTO_VERSION in the desererialize method of msg_version, but maybe that's overkill.

@MarcoFalke MarcoFalke merged commit fa74d3d into bitcoin:master Aug 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

MarcoFalke added a commit that referenced this pull request Aug 23, 2018

Merge #14025: p2p: Remove dead code for nVersion=10300
fa74d3d qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099c p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

  This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1808-netProc10300 branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.