qa: Use named args in validation acceptance tests #14101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2018 12:52
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/(test_witness_block|test_transaction_acceptance)\((self\.nodes\[.\])\.rpc/\1(\2/g' test/functional/p2p_segwit.py -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e "s/sync_blocks\((.*?), (True|False), (1.?), /sync_blocks(\1, success=\2, reject_code=\3, reject_reason=/g" ./test/functional/feature_block.py -END VERIFY SCRIPT-
maflcko
force-pushed
the
Mf1808-qaNamedArgsAcceptance
branch
from
fa910fd
to
fa1c0be
Compare
maflcko
force-pushed
the
Mf1808-qaNamedArgsAcceptance
branch
from
fa1c0be
to
fa782a3
Compare
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
utACK fa782a3. nit, could rename the following bitcoin/test/functional/p2p_segwit.py Line 122 in 4e9a6f8 bitcoin/test/functional/p2p_segwit.py Line 138 in 4e9a6f8 |
|
Concept ACK Clearly improves code readability |
|
utACK fa782a3 |
laanwj
added a commit
that referenced
this pull request
Aug 31, 2018
fa782a3 qa: Use named args in some tests (MarcoFalke) b4d3309 scripted-diff: Use named arguments in feature_block (MarcoFalke) 749ba35 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke) Pull request description: It is confusing to use a list of arguments such as `False, False, 16, ...` where it is unclear what each of them means. Run some scripted diffs to put meaning to them. Tree-SHA512: d768df2375ea3c77145ebb1bf4c2d690581a379031449ded7ae160022d975eb13890aa8c6a44a5eebda8791cb2910a599326e431af76ed9e60afe1d182ada65c
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 25, 2018
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/(test_witness_block|test_transaction_acceptance)\((self\.nodes\[.\])\.rpc/\1(\2/g' test/functional/p2p_segwit.py -END VERIFY SCRIPT- Github-Pull: bitcoin#14101 Rebased-From: 749ba35
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 25, 2018
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e "s/sync_blocks\((.*?), (True|False), (1.?), /sync_blocks(\1, success=\2, reject_code=\3, reject_reason=/g" ./test/functional/feature_block.py -END VERIFY SCRIPT- Github-Pull: bitcoin#14101 Rebased-From: b4d3309
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 25, 2018
Github-Pull: bitcoin#14101 Rebased-From: fa782a3
toxeus
pushed a commit
to toxeus/bitcoin
that referenced
this pull request
Nov 28, 2018
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/(test_witness_block|test_transaction_acceptance)\((self\.nodes\[.\])\.rpc/\1(\2/g' test/functional/p2p_segwit.py -END VERIFY SCRIPT- Github-Pull: bitcoin#14101 Rebased-From: 749ba35
toxeus
pushed a commit
to toxeus/bitcoin
that referenced
this pull request
Nov 28, 2018
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e "s/sync_blocks\((.*?), (True|False), (1.?), /sync_blocks(\1, success=\2, reject_code=\3, reject_reason=/g" ./test/functional/feature_block.py -END VERIFY SCRIPT- Github-Pull: bitcoin#14101 Rebased-From: b4d3309
toxeus
pushed a commit
to toxeus/bitcoin
that referenced
this pull request
Nov 28, 2018
Github-Pull: bitcoin#14101 Rebased-From: fa782a3
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jun 30, 2021
fa782a3 qa: Use named args in some tests (MarcoFalke) b4d3309 scripted-diff: Use named arguments in feature_block (MarcoFalke) 749ba35 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke) Pull request description: It is confusing to use a list of arguments such as `False, False, 16, ...` where it is unclear what each of them means. Run some scripted diffs to put meaning to them. Tree-SHA512: d768df2375ea3c77145ebb1bf4c2d690581a379031449ded7ae160022d975eb13890aa8c6a44a5eebda8791cb2910a599326e431af76ed9e60afe1d182ada65c # Conflicts: # test/functional/feature_block.py # test/functional/mining_basic.py # test/functional/p2p_segwit.py
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 2, 2021
fa782a3 qa: Use named args in some tests (MarcoFalke) b4d3309 scripted-diff: Use named arguments in feature_block (MarcoFalke) 749ba35 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke) Pull request description: It is confusing to use a list of arguments such as `False, False, 16, ...` where it is unclear what each of them means. Run some scripted diffs to put meaning to them. Tree-SHA512: d768df2375ea3c77145ebb1bf4c2d690581a379031449ded7ae160022d975eb13890aa8c6a44a5eebda8791cb2910a599326e431af76ed9e60afe1d182ada65c # Conflicts: # test/functional/feature_block.py # test/functional/mining_basic.py # test/functional/p2p_segwit.py
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 2, 2021
fa782a3 qa: Use named args in some tests (MarcoFalke) b4d3309 scripted-diff: Use named arguments in feature_block (MarcoFalke) 749ba35 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke) Pull request description: It is confusing to use a list of arguments such as `False, False, 16, ...` where it is unclear what each of them means. Run some scripted diffs to put meaning to them. Tree-SHA512: d768df2375ea3c77145ebb1bf4c2d690581a379031449ded7ae160022d975eb13890aa8c6a44a5eebda8791cb2910a599326e431af76ed9e60afe1d182ada65c # Conflicts: # test/functional/feature_block.py # test/functional/mining_basic.py # test/functional/p2p_segwit.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing to use a list of arguments such as
False, False, 16, ...where it is unclear what each of them means.Run some scripted diffs to put meaning to them.