export der always compressed

[fingera]

No description provided.

[laanwj]

Please add rationale to your OP, why is this change?

Also please add at least a test for the new behavior

[randolf]

Please update the description of what this PR does (at present there is no description). Thank you.

[fingera]

BOOST_AUTO_TEST_CASE(key_priv_compress_tests)
{
CKey key;
key.MakeNewKey(false);
BOOST_CHECK(key.GetPrivKey().size() == CKey::PRIVATE_KEY_SIZE);
key.MakeNewKey(true);
BOOST_CHECK(key.GetPrivKey().size() == CKey::COMPRESSED_PRIVATE_KEY_SIZE);
}

[DrahtBot]

Note to reviewers: This pull request conflicts with the following ones:

• Add HKDF_HMAC256_L32 and method to negate a private key #14047 (Add HKDF_HMAC256_L32 and method to negate a private key by jonasschnelli)
• scripted-diff: Rename key size consts to be relative to their class #12461 (scripted-diff: Rename key size consts to be relative to their class by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[laanwj]

Closing, as the goal here has not been explained

[fingera]

it is a bug for ec_privkey_export_der

[sipa]

Please provide a longer rationale. The exported keys seem to work fine so far, so unless you can demonstrate there is a problem with them, this change seems pointless (and wrong; private keys with uncompressed pubkeys should use uncompressed DER in their export).

[fingera]

Is it changing ec_privkey_export_der? Delete another branch that will never be reached

[fingera]

#14195