Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Start to separate wallet from node #14437

Merged
merged 5 commits into from Nov 9, 2018
Merged

Refactor: Start to separate wallet from node #14437

merged 5 commits into from Nov 9, 2018

Commits on Nov 6, 2018

  1. Add skeleton chain and client classes 

    This commit does not change behavior. It just adds new skeleton classes that
don't do anything and aren't instantiated yet.
    @ryanofsky
    ryanofsky committed Nov 6, 2018
    Copy the full SHA
    7e2e62c View commit details
    Browse the repository at this point in the history

  2. Pass chain and client variables where needed 

    This commit does not change behavior. All it does is pass new function
parameters.

It is easiest to review this change with:

    git log -p -n1 -U0 --word-diff-regex=.
    @ryanofsky
    ryanofsky committed Nov 6, 2018
    Copy the full SHA
    8db11dd View commit details
    Browse the repository at this point in the history

  3. Remove direct node->wallet calls in init.cpp 

    Route calls during node initialization and shutdown that would happen between a
node process and wallet processes through the serializable `Chain::Client`
interface, rather than `WalletInitInterface` which is now simpler and only
deals with early initialization and parameter interaction.

This commit mostly does not change behavior. The only change is that the
"Wallet disabled!" and "No wallet support compiled in!" messages are now logged
earlier during startup.
    @ryanofsky
    ryanofsky committed Nov 6, 2018
    Copy the full SHA
    ea961c3 View commit details
    Browse the repository at this point in the history

  4. Remove uses of cs_main in wallet code 

    This commit does not change behavior.

It is easiest to review this change with:

    git log -p -n1 -U0
    @ryanofsky
    ryanofsky committed Nov 6, 2018
    Copy the full SHA
    79d579f View commit details
    Browse the repository at this point in the history

  5. Pass chain locked variables where needed 

    This commit does not change behavior. All it does is pass new function
parameters.

It is easiest to review this change with:

    git log -p -n1 -U0 --word-diff-regex=.
    @ryanofsky
    ryanofsky committed Nov 6, 2018
    1
    Copy the full SHA
    081accb View commit details
    Browse the repository at this point in the history