Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add SegWit support to importmulti #14454
Add support for segwit to importmulti, supports P2WSH, P2WPKH, P2SH-P2WPKH, P2SH-P2WSH. Adds a new
Also includes some tests for the various import types.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
This was referenced
Oct 10, 2018
achow101 left a comment
59f8e547130fc1cb756da7d990f65445ca196f5f could be squashed into 24092b3402693d8a2c39b640db18748b168863e9
acdba74ee011bfcafc9f28b528918815b1de4920 seems to be an unrelated change
@meshcollider I don't think it's necessary to import the pubkeys involved separately anymore since #14424, and in fact that sounds very dangerous (you could be tricked into importing a 2-of-3 multisig where you have 2 of the keys, but then receiving a payment to a P2PKH of the third key, and seeing it treated towards your watch-only balance). NACK until that is fixed (or at least restricted to not have that issue, but I believe that rebasing on 14424 will be sufficient).
I think there are a few things that need fixing:
referenced this pull request
Oct 22, 2018
Sjors left a comment
I added a few more questions inline, hopefully merely to reduce my own confusion.
This is done now by checking properties via
Some of the
I think this one is still missing for P2WSH multisig, between the
Where "spendable" means
I made a commit that checks