Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear function argument case in dev notes #14625

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
6 participants
@dongcarl
Copy link
Contributor

commented Nov 1, 2018

Rationale:

For new developers, they might be confused if they see that function arguments are sometimes camelCase'd in the codebase. This makes it clear that they should be snake_case'd (maybe because no one's gotten to fixing them yet).

@fanquake fanquake added the Docs label Nov 1, 2018

@fanquake

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

@ken2812221

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

ACK 9605bbd

1 similar comment
@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

ACK 9605bbd

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

ACK 9605bbd

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

we discussed this on IRC
thanks !
utACK 9605bbd

@laanwj laanwj merged commit 9605bbd into bitcoin:master Nov 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 1, 2018

Merge #14625: Make clear function argument case in dev notes
9605bbd Make clear function argument case in dev notes (Carl Dong)

Pull request description:

  Rationale:

  For new developers, they might be confused if they see that function arguments are sometimes `camelCase`'d in the codebase. This makes it clear that they _should_ be `snake_case`'d (maybe because no one's gotten to fixing them yet).

Tree-SHA512: 9db16d1fedf9761121844a0865ae3fefea94b5dbdfb36cb18f99cbc73e117f7d798a019f28a1c8bca19772502de2f9ed063f03bd911ffc4d248ec7386cd87d97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.