fix a memory leak in key.cpp #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add EC_KEY_free() in CKey::Reset() when pkey != NULL - init pkey with NULL in CKey constructor
|
ACK. |
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
fix a memory leak in key.cpp
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
…ass. a1819b5 [Wallet] Clean pwalletMain wrong usage inside wallet.cpp . (furszy) ef3ca99 [Wallet] Clean more pwalletMain wrong usage in wallet_zerocoin. (furszy) 0dc1120 [Move-only] Move GetDeterministicSeed & AddDeterministicSeed to legacy wallet_zerocoin. (furszy) 1ed1b5f [Wallet] Cleanup wrong pwalletMain usage in wallet_zerocoin.cpp (furszy) Pull request description: Essentially `wallet.cpp`, `crypter.cpp` and `wallet_zerocoin.cpp` were wrongly using/calling `pwalletMain` when those files are actually THE WALLET. This was blocking the `CWallet` object usage in unit test as the wallet (or any other wallet created that it's not `pwalletMain`) would be calling a pointer that could or couldn't exist when it should just call an internal method. ACKs for top commit: random-zebra: Big ACK a1819b5 here. Fuzzbawls: ACK a1819b5 Tree-SHA512: b978f842aa08f72905dd2210ad84cdea2399baf01bdf0b7d14015b9f005829c4a50c204ad57ba3c91cc261dc0ac1e8cb70205256b423feedfdad9d4022a80336
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1474