CBigNum: Convert negative int64 values in a more well-defined way #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the minimum signed integer cannot be represented as positive so long as its type is signed, and it's not well-defined what happens if you make it unsigned before negating it, we instead increment the negative integer by 1, convert it, then increment the (now positive) unsigned integer by 1 to compensate
Merged
gmaxwell
added a commit
that referenced
this pull request
Jul 11, 2012
CBigNum: Convert negative int64 values in a more well-defined way
nifgraup
pushed a commit
to nifgraup/auroracoin-project
that referenced
this pull request
Mar 30, 2014
CBigNum: Convert negative int64 values in a more well-defined way
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
Adds several unittests for CAddrMan and CAddrInfo. Increases the accuracy of addrman tests. Removes non-determinism in tests by overriding the random number generator. Extracts testing code from addrman class to test class.
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
…ist-conf 8efee92 [Trivial][RPC] Remove references to old command list-conf (random-zebra) Pull request description: `startmasternode` and `createmasternodebroadcast` error outputs are still referencing old command `list-conf` (deprecated since version v2.3.1). Replace with `listmasternodeconf`. Closes bitcoin#1496 ACKs for top commit: furszy: utACK 8efee92 Fuzzbawls: utACK 8efee92 Tree-SHA512: 882a6bc00d8af03408f7894486b7e4b7e9ebd28cdf3b9876aa47ccecc6440d657b1d2a47e9cf26ec8a013fbaf788fe48cb934493fee5819468e4abcfc77f4d1f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the minimum signed integer cannot be represented as positive so long as its type is signed, and it's not well-defined what happens if you make it unsigned before negating it, we instead increment the negative integer by 1, convert it, then increment the (now positive) unsigned integer by 1 to compensate
@wizeman recently introduced this potential-bug in #1298, so I'd appreciate if he could comment (did not get a response on IRC)