Add option to create an encrypted wallet #15006

achow101 · 2018-12-19T21:35:45Z

This PR adds a new passphrase argument to createwallet which will create a wallet that is encrypted with that passphrase.

This is built on #15226 because it needs to first create an empty wallet, then encrypt the empty wallet and generate new keys that have only been stored in an encrypted state.

DrahtBot · 2018-12-20T00:36:44Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15937 (WIP: Add loadwallet and createwallet load_on_startup options by ryanofsky)
#13756 (wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jonasschnelli · 2018-12-20T01:13:07Z

Concept ACK

Sjors · 2018-12-20T11:17:33Z

Concept ACK.

Today on IRC:

jnewbery · 2018-12-20T19:29:43Z

Concept ACK

practicalswift · 2018-12-21T08:50:31Z

test/functional/wallet_createwallet.py

+        self.log.info("Test disableprivatekeys creation.")
+        self.nodes[0].createwallet('w1', True)
+        w1 = node.get_wallet_rpc('w1')
+        assert_raises_rpc_error(-4,"Error: Private keys are disabled for this wallet", w1.getnewaddress)


~~Missing whitespace after ,. Please run this newly added file through black to make sure formatting is correct :-)~~

@practicalswift that's an upstream test from #14938, where this has been fixed.

laanwj · 2019-01-02T12:26:23Z

Concept ACK

laanwj · 2019-01-21T19:10:10Z

This fails travis:

Assertion failed: lock cs_wallet not held in wallet/wallet.cpp:1389; locks held:
FAIL qt/test/test_bitcoin-qt (exit status: 134)

achow101 · 2019-01-21T20:02:17Z

Fixed by rebasing

achow101 · 2019-01-22T03:53:00Z

I've decided to base this on #15226 instead of #14938.

achow101 · 2019-01-29T19:57:19Z

Rebased

laanwj · 2019-01-31T13:12:14Z

src/interfaces/wallet.cpp

@@ -488,6 +488,10 @@ class WalletImpl : public Wallet
    {
        return MakeHandler(m_wallet.NotifyWatchonlyChanged.connect(fn));
    }
+    std::unique_ptr<Handler> handleCanGetAddressesChanged(CanGetAddressesChangedFn fn) override


handleCanGetAddressesChanged is a terrible method name in itself, took me at least 5 minutes to decode it, please add a comment saying it's a handler for changes in whether addresses can be generated or not :-)

That's a change from #15225 and out of scope for this pr. sorry.

Fwiw I find it easy enough to read, but I'm used to similar nomenclature from iOs :-)

laanwj · 2019-01-31T13:14:42Z

test/functional/test_framework/test_node.py

@@ -434,7 +434,7 @@ def batch(self, requests):
    def send_cli(self, command=None, *args, **kwargs):
        """Run bitcoin-cli command. Deserializes returned string as python object."""
        pos_args = [str(arg).lower() if type(arg) is bool else str(arg) for arg in args]
-        named_args = [str(key) + "=" + str(value) for (key, value) in kwargs.items()]
+        named_args = [str(key) + "=" + (str(value).lower() if type(value) is bool else str(value)) for (key, value) in kwargs.items()]


I remember I had a comment on this (please factor out the value→cli functionality to a function instead of duplicating it) but somehow it got lost …

Since this issue affects multiple PRs, I've split the fix into a separate PR: #15301

hmmm, bizarre. You definitely did have a comment here because I responded to it!

This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.

Summary: bitcoin/bitcoin@662d117 --- Backport of Core [[bitcoin/bitcoin#15006 | PR15006]] Test Plan: ninja check ./test/functional/test_runner.py wallet_createwallet.py Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6423

This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.

fanquake added the Wallet label Dec 19, 2018

achow101 force-pushed the create-encrypted-wallet branch from 73efe2b to 1733089 Compare December 20, 2018 05:19

Sjors mentioned this pull request Dec 20, 2018

Support creating an empty wallet #14938

Closed

bitcoin deleted a comment from achow101 Dec 20, 2018

achow101 force-pushed the create-encrypted-wallet branch from 1733089 to 3205e6e Compare December 20, 2018 19:02

practicalswift reviewed Dec 21, 2018

View reviewed changes

achow101 force-pushed the create-encrypted-wallet branch 2 times, most recently from 780a296 to 3f17cbe Compare January 21, 2019 20:02

achow101 force-pushed the create-encrypted-wallet branch from 3f17cbe to e2f447f Compare January 22, 2019 03:52

achow101 force-pushed the create-encrypted-wallet branch 2 times, most recently from 18886a2 to b7918ad Compare January 23, 2019 21:00

DrahtBot added the Needs rebase label Jan 29, 2019

achow101 force-pushed the create-encrypted-wallet branch from b7918ad to 51a477f Compare January 29, 2019 19:57

DrahtBot removed the Needs rebase label Jan 29, 2019

laanwj reviewed Jan 31, 2019

View reviewed changes

DrahtBot added the Needs rebase label Jan 31, 2019

achow101 force-pushed the create-encrypted-wallet branch from 51a477f to f2bed74 Compare January 31, 2019 15:41

DrahtBot added Needs rebase and removed Needs rebase labels Jan 31, 2019

achow101 force-pushed the create-encrypted-wallet branch from f2bed74 to 5e3d2b9 Compare February 1, 2019 15:40

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to create an encrypted wallet #15006

Add option to create an encrypted wallet #15006

achow101 commented Dec 19, 2018 •

edited

DrahtBot commented Dec 20, 2018 •

edited

jonasschnelli commented Dec 20, 2018

Sjors commented Dec 20, 2018

jnewbery commented Dec 20, 2018

practicalswift Dec 21, 2018 •

edited

Sjors Dec 21, 2018

laanwj commented Jan 2, 2019

laanwj commented Jan 21, 2019

achow101 commented Jan 21, 2019

achow101 commented Jan 22, 2019

achow101 commented Jan 29, 2019

laanwj Jan 31, 2019

achow101 Jan 31, 2019

Sjors Jan 31, 2019

laanwj Jan 31, 2019 •

edited

achow101 Jan 31, 2019

jnewbery Jan 31, 2019

Add option to create an encrypted wallet #15006

Add option to create an encrypted wallet #15006

Conversation

achow101 commented Dec 19, 2018 • edited

DrahtBot commented Dec 20, 2018 • edited

Conflicts

jonasschnelli commented Dec 20, 2018

Sjors commented Dec 20, 2018

jnewbery commented Dec 20, 2018

practicalswift Dec 21, 2018 • edited

Choose a reason for hiding this comment

Sjors Dec 21, 2018

Choose a reason for hiding this comment

laanwj commented Jan 2, 2019

laanwj commented Jan 21, 2019

achow101 commented Jan 21, 2019

achow101 commented Jan 22, 2019

achow101 commented Jan 29, 2019

laanwj Jan 31, 2019

Choose a reason for hiding this comment

achow101 Jan 31, 2019

Choose a reason for hiding this comment

Sjors Jan 31, 2019

Choose a reason for hiding this comment

laanwj Jan 31, 2019 • edited

Choose a reason for hiding this comment

achow101 Jan 31, 2019

Choose a reason for hiding this comment

jnewbery Jan 31, 2019

Choose a reason for hiding this comment

achow101 commented Dec 19, 2018 •

edited

DrahtBot commented Dec 20, 2018 •

edited

practicalswift Dec 21, 2018 •

edited

laanwj Jan 31, 2019 •

edited