New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] tidy up wallet_importmulti.py #15108
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| #!/usr/bin/env python3 | ||
| # Copyright (c) 2018 The Bitcoin Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
| """Useful util functions for testing the wallet""" | ||
| from collections import namedtuple | ||
|
|
||
| from test_framework.address import ( | ||
| key_to_p2pkh, | ||
| key_to_p2sh_p2wpkh, | ||
| key_to_p2wpkh, | ||
| script_to_p2sh, | ||
| script_to_p2sh_p2wsh, | ||
| script_to_p2wsh, | ||
| ) | ||
| from test_framework.script import ( | ||
| CScript, | ||
| OP_0, | ||
| OP_2, | ||
| OP_3, | ||
| OP_CHECKMULTISIG, | ||
| OP_CHECKSIG, | ||
| OP_DUP, | ||
| OP_EQUAL, | ||
| OP_EQUALVERIFY, | ||
| OP_HASH160, | ||
| hash160, | ||
| sha256, | ||
| ) | ||
| from test_framework.util import hex_str_to_bytes | ||
|
|
||
| Key = namedtuple('Key', ['privkey', | ||
| 'pubkey', | ||
| 'p2pkh_script', | ||
| 'p2pkh_addr', | ||
| 'p2wpkh_script', | ||
| 'p2wpkh_addr', | ||
| 'p2sh_p2wpkh_script', | ||
| 'p2sh_p2wpkh_redeem_script', | ||
| 'p2sh_p2wpkh_addr']) | ||
|
|
||
| Multisig = namedtuple('Multisig', ['privkeys', | ||
| 'pubkeys', | ||
| 'p2sh_script', | ||
| 'p2sh_addr', | ||
| 'redeem_script', | ||
| 'p2wsh_script', | ||
| 'p2wsh_addr', | ||
| 'p2sh_p2wsh_script', | ||
| 'p2sh_p2wsh_addr']) | ||
|
|
||
| def get_key(node): | ||
| """Generate a fresh key on node | ||
|
|
||
| Returns a named tuple of privkey, pubkey and all address and scripts.""" | ||
| addr = node.getnewaddress() | ||
| pubkey = node.getaddressinfo(addr)['pubkey'] | ||
| pkh = hash160(hex_str_to_bytes(pubkey)) | ||
| return Key(privkey=node.dumpprivkey(addr), | ||
| pubkey=pubkey, | ||
| p2pkh_script=CScript([OP_DUP, OP_HASH160, pkh, OP_EQUALVERIFY, OP_CHECKSIG]).hex(), | ||
| p2pkh_addr=key_to_p2pkh(pubkey), | ||
| p2wpkh_script=CScript([OP_0, pkh]).hex(), | ||
| p2wpkh_addr=key_to_p2wpkh(pubkey), | ||
| p2sh_p2wpkh_script=CScript([OP_HASH160, hash160(CScript([OP_0, pkh])), OP_EQUAL]).hex(), | ||
| p2sh_p2wpkh_redeem_script=CScript([OP_0, pkh]).hex(), | ||
| p2sh_p2wpkh_addr=key_to_p2sh_p2wpkh(pubkey)) | ||
|
|
||
| def get_multisig(node): | ||
| """Generate a fresh 2-of-3 multisig on node | ||
|
|
||
| Returns a named tuple of privkeys, pubkeys and all address and scripts.""" | ||
| addrs = [] | ||
| pubkeys = [] | ||
| for _ in range(3): | ||
| addr = node.getaddressinfo(node.getnewaddress()) | ||
| addrs.append(addr['address']) | ||
| pubkeys.append(addr['pubkey']) | ||
| script_code = CScript([OP_2] + [hex_str_to_bytes(pubkey) for pubkey in pubkeys] + [OP_3, OP_CHECKMULTISIG]) | ||
| witness_script = CScript([OP_0, sha256(script_code)]) | ||
| return Multisig(privkeys=[node.dumpprivkey(addr) for addr in addrs], | ||
| pubkeys=pubkeys, | ||
| p2sh_script=CScript([OP_HASH160, hash160(script_code), OP_EQUAL]).hex(), | ||
| p2sh_addr=script_to_p2sh(script_code), | ||
| redeem_script=script_code.hex(), | ||
| p2wsh_script=witness_script.hex(), | ||
| p2wsh_addr=script_to_p2wsh(script_code), | ||
| p2sh_p2wsh_script=CScript([OP_HASH160, witness_script, OP_EQUAL]).hex(), | ||
| p2sh_p2wsh_addr=script_to_p2sh_p2wsh(script_code)) | ||
|
|
||
| def test_address(node, address, **kwargs): | ||
| """Get address info for `address` and test whether the returned values are as expected.""" | ||
| addr_info = node.getaddressinfo(address) | ||
| for key, value in kwargs.items(): | ||
| if value is None: | ||
| if key in addr_info.keys(): | ||
| raise AssertionError("key {} unexpectedly returned in getaddressinfo.".format(key)) | ||
| elif addr_info[key] != value: | ||
| raise AssertionError("key {} value {} did not match expected value {}".format(key, addr_info[key], value)) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was authored in 2018 (according to the git author date), so I guess it is fine.