wallet: Added function to remove transactions that are no longer in wallet #15130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
wallet_remove_old_txs
branch
from
348096b
to
f41906c
Compare
promag
reviewed
Jan 9, 2019
| @@ -875,6 +875,22 @@ bool CWallet::AddToWallet(const CWalletTx& wtxIn, bool fFlushOnClose) | |||
| return true; | |||
| } | |||
|
|
|||
| bool CWallet::RemoveFromWallet(const CTransaction& tx) | |||
| { | |||
| LOCK(cs_wallet); | |||
| if (IsMine(tx) || IsFromMe(tx)) | ||
| return AddToWallet(wtx, false); | ||
|
|
||
| return RemoveFromWallet(tx); |
There was a problem hiding this comment.
Does it make sense to return the result of RemoveFromWallet in AddToWalletIfInvolvingMe?
| WalletLogPrintf("RemoveFromWallet %s\n", tx.GetHash().ToString()); | ||
|
|
||
| // Notify UI of removed transaction | ||
| NotifyTransactionChanged(this, tx.GetHash(), CT_DELETED); |
This might be required for another pull, but makes no sense on its own IIUC |
|
Yes, when I suggested to split I meant to make this one rebased on that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rescanning a wallet for transactions, it will remove transactions that are no longer in the wallet.
Required for #15129