Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explain AcceptToMemoryPoolWorker's coins_to_uncache #15267

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

jamesob
Copy link
Member

@jamesob jamesob commented Jan 25, 2019

I found ATMPW's coins_to_uncache a little hard to understand (see #15264). This adds some doc for posterity.

@fanquake fanquake added the Docs label Jan 25, 2019
src/coins.h Outdated Show resolved Hide resolved
Copy link
Member

@sdaftuar sdaftuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, I'm all in favor of making stuff like this more understandable.

src/coins.h Show resolved Hide resolved
src/validation.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3ad03db

src/validation.cpp Outdated Show resolved Hide resolved
src/coins.h Show resolved Hide resolved
@jamesob jamesob force-pushed the 2019-01-atmpw-uncache-coins-doc branch from 3ad03db to 560caca Compare February 22, 2019 16:19
@jamesob
Copy link
Member Author

jamesob commented Feb 22, 2019

Thanks for the review. Pushed an update incorporating feedback.

@jnewbery
Copy link
Contributor

Looks good to me! ACK 560caca

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 8, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@jnewbery
Copy link
Contributor

@laanwj @sdaftuar care to reACK? Should be harmless to merge this if you're happy with the comments.

src/validation.cpp Outdated Show resolved Hide resolved
@jamesob jamesob force-pushed the 2019-01-atmpw-uncache-coins-doc branch from 560caca to 5d26205 Compare April 26, 2019 14:01
@sdaftuar
Copy link
Member

Thanks for updating, utACK

@jnewbery
Copy link
Contributor

ACK 5d26205

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Apr 26, 2019
…_uncache

5d26205 doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (James O'Beirne)

Pull request description:

  I found ATMPW's `coins_to_uncache` a little hard to understand (see bitcoin#15264). This adds some doc for posterity.

ACKs for commit 5d2620:
  jnewbery:
    ACK 5d26205

Tree-SHA512: 088508fa78012fab8680663c4e30f5cee29768416c2ca8b8b2abc29b6ac7067c5a589674f0254474a7ccc95477889d41719760f5796792bf492f51b3dd499c6c
@maflcko maflcko merged commit 5d26205 into bitcoin:master Apr 26, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jul 5, 2020
…ache

Summary:
bitcoin/bitcoin@5d26205

---

Backport of Core [[bitcoin/bitcoin#15267 | PR15267]]

Test Plan: none

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6819
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 19, 2021
…_uncache

5d26205 doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (James O'Beirne)

Pull request description:

  I found ATMPW's `coins_to_uncache` a little hard to understand (see bitcoin#15264). This adds some doc for posterity.

ACKs for commit 5d2620:
  jnewbery:
    ACK 5d26205

Tree-SHA512: 088508fa78012fab8680663c4e30f5cee29768416c2ca8b8b2abc29b6ac7067c5a589674f0254474a7ccc95477889d41719760f5796792bf492f51b3dd499c6c
vijaydasmp added a commit to vijaydasmp/dash that referenced this pull request Oct 19, 2021
vijaydasmp added a commit to vijaydasmp/dash that referenced this pull request Oct 20, 2021
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants