-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: explain AcceptToMemoryPoolWorker's coins_to_uncache #15267
doc: explain AcceptToMemoryPoolWorker's coins_to_uncache #15267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, I'm all in favor of making stuff like this more understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 3ad03db
3ad03db
to
560caca
Compare
Thanks for the review. Pushed an update incorporating feedback. |
Looks good to me! ACK 560caca |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
560caca
to
5d26205
Compare
Thanks for updating, utACK |
ACK 5d26205 |
…_uncache 5d26205 doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (James O'Beirne) Pull request description: I found ATMPW's `coins_to_uncache` a little hard to understand (see bitcoin#15264). This adds some doc for posterity. ACKs for commit 5d2620: jnewbery: ACK 5d26205 Tree-SHA512: 088508fa78012fab8680663c4e30f5cee29768416c2ca8b8b2abc29b6ac7067c5a589674f0254474a7ccc95477889d41719760f5796792bf492f51b3dd499c6c
…ache Summary: bitcoin/bitcoin@5d26205 --- Backport of Core [[bitcoin/bitcoin#15267 | PR15267]] Test Plan: none Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6819
…_uncache 5d26205 doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (James O'Beirne) Pull request description: I found ATMPW's `coins_to_uncache` a little hard to understand (see bitcoin#15264). This adds some doc for posterity. ACKs for commit 5d2620: jnewbery: ACK 5d26205 Tree-SHA512: 088508fa78012fab8680663c4e30f5cee29768416c2ca8b8b2abc29b6ac7067c5a589674f0254474a7ccc95477889d41719760f5796792bf492f51b3dd499c6c
I found ATMPW's
coins_to_uncache
a little hard to understand (see #15264). This adds some doc for posterity.