Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: replace testnet with chain and return network name as per BIP70. #15566

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
6 participants
@fanquake
Copy link
Member

commented Mar 9, 2019

Related IRC discussion here (line 151).

@luke-jr

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Shouldn't we retain "testnet" for compatibility, for now?

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Shouldn't we retain "testnet" for compatibility, for now?

Now that it's client-side, IMO there's no strict need for keeping compatibility at all (you could always use a different bitcoin-cli executable). We've already let this linger for way too long.

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

ACK 890396c

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

ACK 890396c

@Empact

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

utACK 890396c

nit: I also like the idea of explicit deprecation

@IlyasRidhuan

This comment has been minimized.

Copy link

commented Mar 10, 2019

ACK 890396c

@MarcoFalke MarcoFalke merged commit 890396c into bitcoin:master Mar 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Mar 11, 2019

Merge #15566: cli: replace testnet with chain and return network name…
… as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0

@fanquake fanquake deleted the fanquake:cli-testnet-to-network branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.