Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: replace testnet with chain and return network name as per BIP70. #15566

Merged
merged 1 commit into from Mar 11, 2019
Merged

cli: replace testnet with chain and return network name as per BIP70. #15566

merged 1 commit into from Mar 11, 2019

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Mar 9, 2019

Related IRC discussion here (line 151).

@luke-jr
Copy link
Member

luke-jr commented Mar 9, 2019

Shouldn't we retain "testnet" for compatibility, for now?

@laanwj
Copy link
Member

laanwj commented Mar 9, 2019

Shouldn't we retain "testnet" for compatibility, for now?

Now that it's client-side, IMO there's no strict need for keeping compatibility at all (you could always use a different bitcoin-cli executable). We've already let this linger for way too long.

@laanwj
Copy link
Member

laanwj commented Mar 9, 2019

ACK 890396c

@maflcko
Copy link
Member

maflcko commented Mar 9, 2019

ACK 890396c

@Empact
Copy link
Member

Empact commented Mar 9, 2019

utACK 890396c

nit: I also like the idea of explicit deprecation

@IlyasRidhuan
Copy link

ACK 890396c

@maflcko maflcko merged commit 890396c into bitcoin:master Mar 11, 2019
maflcko pushed a commit that referenced this pull request Mar 11, 2019
Merge #15566: cli: replace testnet with chain and return network name…
887f57e 
… as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
@fanquake fanquake deleted the cli-testnet-to-network branch March 11, 2019 22:55
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 2, 2020
@fanquake @PiRK
cli: replace testnet with chain and return network name as per BIP70.
406bb3c 
Summary: Backport of Core [[bitcoin/bitcoin#15566 | PR15566]]

Test Plan:
`ninja && ninja check-functional`

Install and test:
`bitcoin-cli -getinfo`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7734
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Sep 21, 2021
@Munkybooty
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
ca73e04 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Sep 21, 2021
@Munkybooty
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
b8d214a 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Sep 27, 2021
@Munkybooty
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
52bbfc0 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Sep 27, 2021
@Munkybooty
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
046bae2 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Sep 30, 2021
@Munkybooty
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
6011ac4 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Oct 1, 2021
@Munkybooty
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
1e0aa63 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 12, 2021
@kwvg
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
27d3173 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
@pravblockc
Merge bitcoin#15566: cli: replace testnet with chain and return netwo…
5d0ae49 
…rk name as per BIP70.

890396c cli: replace testnet with chain and return network name as per BIP70. (fanquake)

Pull request description:

  Related IRC discussion [here (line 151)](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-09.html).

Tree-SHA512: 8bdbacc7b8ce8bd2cc7c47aa9d73f2830a7c2e2ec43686430e3fba1a9db0e53a285467f26cde6dcc3bf948b7d6d59b9b7f184ce1a30a8970f39e5396dfc122f0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Utils/log/libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fanquake @luke-jr @laanwj @maflcko @Empact @IlyasRidhuan