Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change window titles to "Bitcoin-Qt - <purpose>" / misc related renames #1620

Closed
wants to merge 1 commit into from

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Jul 22, 2012

  • This helps user to not think the client is called "Bitcoin"

optionsAction->setMenuRole(QAction::PreferencesRole);
toggleHideAction = new QAction(QIcon(":/icons/bitcoin"), tr("Show/Hide &Bitcoin"), this);
toggleHideAction->setToolTip(tr("Show or hide the Bitcoin window"));
toggleHideAction = new QAction(QIcon(":/icons/bitcoin"), tr("Show/Hide &Bitcoin-Qt"), this);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a pull that removes any client name. Simply Show / Hide.

@Diapolo
Copy link

Diapolo commented Jul 22, 2012

In general I like to put the name Bitcoin-Qt in place as official client name, I just think it needs a finer thinking about where it makes sense and how.

- This helps user to not think the client is called "Bitcoin"
@laanwj
Copy link
Member

laanwj commented Jul 23, 2012

NACK. I've been clear on this before. End users have no idea what "Qt" is, so it shouldn't appear that prominently in the interface. It's just a technical detail. Like putting the programming language in the title.

The focus should be on "Bitcoin" itself, not that it is a UI or what library happens to be used to build it.

@luke-jr
Copy link
Member Author

luke-jr commented Jul 23, 2012

@laanwj It's the client name. How are users to differentiate Bitcoin-Qt from other clients they may have installed? Specific clients shouldn't claim to be "Bitcoin" or it will confuse users into thinking Bitcoin is the software.

@laanwj
Copy link
Member

laanwj commented Jul 23, 2012

That's not the client name. I think that's where the confusion comes from. Bitcoin-qt is the name of the UI project before it got merged into here. And the focus should be on the underlying system, not the UI. If this client has any name beyond "Bitcoin reference client" it's "Satoshi".

@laanwj
Copy link
Member

laanwj commented Jul 23, 2012

Anyway, I'm fine with any name but I think naming should be @gavinandresen 's call as project lead.

@luke-jr
Copy link
Member Author

luke-jr commented Jul 23, 2012

I guess I see it as the same Bitcoin-Qt project mainly by @laanwj (ie, same maintainer = same project), and @gavinandresen the project lead of bitcoin_d_ (which happens to share the same git repository). I don't really care what you choose to name the client, but some distinction between Bitcoin and this Bitcoin client is needed.

@Diapolo
Copy link

Diapolo commented Jul 23, 2012

Just for clarification, bitcoind is also a Bitcoin client, yes? When someone talks about bitcoind my association is hey that's the official / reference command-line Bitcoin client. If one talks about Bitcoin-Qt I associate the official / reference GUI Bitcoin client with it. That's no pro or con, I just want to understand what others read from a certain name.

To summarize:
Bitcoin as the concept / protocol / technique
bitcoind as command-line client using Bitcoin
Bitcoin-Qt as GUI client using bitcoind

@luke-jr
Copy link
Member Author

luke-jr commented Jul 23, 2012

As I see it:

  • Bitcoin as the concept / protocol / technique / blockchain
  • "Satoshi" as the reference protocol implementation began by Satoshi Nakamoto, maintained by @gavinandresen
  • bitcoind as the JSON-RPC server began by Satoshi Nakamoto, maintained by @gavinandresen
  • Bitcoin-Qt as GUI client began and maintained by @laanwj

@gavinandresen
Copy link
Contributor

I agree with laanwj, it's fine the way it is.

suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
* fix CMasternode::CalculateScore, new mn score algo activation is triggered by DIP0001 lock-in

* unify rank calculation, base it on full mn vector rather than using active mns only

* bump CMasternodeMan::SERIALIZATION_VERSION_STRING

* unify rank calculations even further

* fix (partially revert previous one)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants