-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change window titles to "Bitcoin-Qt - <purpose>" / misc related renames #1620
Conversation
luke-jr
commented
Jul 22, 2012
- This helps user to not think the client is called "Bitcoin"
optionsAction->setMenuRole(QAction::PreferencesRole); | ||
toggleHideAction = new QAction(QIcon(":/icons/bitcoin"), tr("Show/Hide &Bitcoin"), this); | ||
toggleHideAction->setToolTip(tr("Show or hide the Bitcoin window")); | ||
toggleHideAction = new QAction(QIcon(":/icons/bitcoin"), tr("Show/Hide &Bitcoin-Qt"), this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a pull that removes any client name. Simply Show / Hide.
In general I like to put the name |
- This helps user to not think the client is called "Bitcoin"
NACK. I've been clear on this before. End users have no idea what "Qt" is, so it shouldn't appear that prominently in the interface. It's just a technical detail. Like putting the programming language in the title. The focus should be on "Bitcoin" itself, not that it is a UI or what library happens to be used to build it. |
@laanwj It's the client name. How are users to differentiate Bitcoin-Qt from other clients they may have installed? Specific clients shouldn't claim to be "Bitcoin" or it will confuse users into thinking Bitcoin is the software. |
That's not the client name. I think that's where the confusion comes from. Bitcoin-qt is the name of the UI project before it got merged into here. And the focus should be on the underlying system, not the UI. If this client has any name beyond "Bitcoin reference client" it's "Satoshi". |
Anyway, I'm fine with any name but I think naming should be @gavinandresen 's call as project lead. |
I guess I see it as the same Bitcoin-Qt project mainly by @laanwj (ie, same maintainer = same project), and @gavinandresen the project lead of bitcoin_d_ (which happens to share the same git repository). I don't really care what you choose to name the client, but some distinction between Bitcoin and this Bitcoin client is needed. |
Just for clarification, bitcoind is also a Bitcoin client, yes? When someone talks about bitcoind my association is hey that's the official / reference command-line Bitcoin client. If one talks about Bitcoin-Qt I associate the official / reference GUI Bitcoin client with it. That's no pro or con, I just want to understand what others read from a certain name. To summarize: |
As I see it:
|
I agree with laanwj, it's fine the way it is. |
* fix CMasternode::CalculateScore, new mn score algo activation is triggered by DIP0001 lock-in * unify rank calculation, base it on full mn vector rather than using active mns only * bump CMasternodeMan::SERIALIZATION_VERSION_STRING * unify rank calculations even further * fix (partially revert previous one)