Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Include static members in Doxygen #16347

Merged
merged 1 commit into from Jul 8, 2019

Conversation

dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Jul 6, 2019

This makes our Doxygen output more useful by generating them for static members.

@dongcarl dongcarl added the Docs label Jul 6, 2019
@practicalswift
Copy link
Contributor

ACK 84ad4d2

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 84ad4d2

Tested by generating the Doxygen docs for master (f373bee) and 84ad4d2

master:
master

#16347:
16347

@fanquake
Copy link
Member

fanquake commented Jul 8, 2019

@laanwj Could you take a quick look here, given this will affect https://dev.visucore.com/bitcoin/doxygen/.

@laanwj
Copy link
Member

laanwj commented Jul 8, 2019

I don't see why not
I wonder what my original rationale was for not setting it, but might have missed the option, or maybe it didn't exist back then.

ACK 84ad4d2

@laanwj laanwj merged commit 84ad4d2 into bitcoin:master Jul 8, 2019
laanwj added a commit that referenced this pull request Jul 8, 2019
84ad4d2 doc: Include static members in Doxygen (Carl Dong)

Pull request description:

  This makes our Doxygen output more useful by generating them for static members.

ACKs for top commit:
  practicalswift:
    ACK 84ad4d2
  laanwj:
    ACK 84ad4d2
  fanquake:
    ACK 84ad4d2

Tree-SHA512: f47fe6f36739ba8d7978169b28a29ad3d0796d7535052e447740077f4827c9bf5082d14c9cac2fbaf91f01bb2bffc25d9d7c3f702c0848c79a48a311ebd3344f
@laanwj
Copy link
Member

laanwj commented Jul 8, 2019

I've regenerated the documentation, should include static members now

@maflcko
Copy link
Member

maflcko commented Jul 8, 2019

Thanks. I've always wondered why so much was missing from the doxygen

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 9, 2019
84ad4d2 doc: Include static members in Doxygen (Carl Dong)

Pull request description:

  This makes our Doxygen output more useful by generating them for static members.

ACKs for top commit:
  practicalswift:
    ACK 84ad4d2
  laanwj:
    ACK bitcoin@84ad4d2
  fanquake:
    ACK 84ad4d2

Tree-SHA512: f47fe6f36739ba8d7978169b28a29ad3d0796d7535052e447740077f4827c9bf5082d14c9cac2fbaf91f01bb2bffc25d9d7c3f702c0848c79a48a311ebd3344f
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 13, 2020
Summary:
> This makes our Doxygen output more useful by generating it for static members.

This is a backport of Core [[bitcoin/bitcoin#16347 | PR16347]]

Test Plan: `cmake .. -GNinja && ninja doc-doxygen`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8377
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants