-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'mempool' P2P command, and extend 'getdata' behavior #1641
Conversation
to permit downloading of mempool transactions from the remote peer.
@gmaxwell was asking about testing. This was tested successfully with a one-line pynode patch (pynode HEAD deb07f51435cd0d18596bddfee28e337a5a6454e). pynode issues 'mempool' at startup, and fills its own mempool with the returned results.
|
Random thought: miners may want this, to "prime the pump" after restarting their bitcoind. There is the incentive to capture every fee-paying transactions, after all. |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/05a85b2b38d516a8701f684fcd2ab99f3e5b462d for binaries and test log. |
ACK on the changes, but maybe there must at least be some discussion about adding this, and the protocol version change involved. An alternative would be using a service bit (I don't personally think that is preferable), but people may have other opinions. I would expect the startup sequence to also send a mempool command to another node, in case it reports protocol version 60002 or higher? |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/05f891636199c36e1639fb95f5e92445eea9e97f for binaries and test log. |
Specification: https://en.bitcoin.it/wiki/BIP_0035 |
ACK |
1 similar comment
ACK |
Add 'mempool' P2P command, and extend 'getdata' behavior
This reverts commit d3829e5. Reverting and postponing the fix till later. Probably should write a DIP and explore different options first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1989
Add 'mempool' P2P command, and extend 'getdata' behavior to permit downloading of mempool transactions from the remote peer.