Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix test failures #16493

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jul 30, 2019

@DrahtBot DrahtBot added the Tests label Jul 30, 2019
@maflcko maflcko changed the title test: Bump rpc_timeout in feature_dbcrash test: Fix test failures in feature_dbcrash Jul 30, 2019
@maflcko maflcko changed the title test: Fix test failures in feature_dbcrash test: Fix test failures Aug 1, 2019
@maflcko
Copy link
Member Author

maflcko commented Aug 1, 2019

This fixes three known test failures by adjusting incorrectly set test params in set_test_params. Shouldn't be too hard to review and would make it easier to hunt the other test failures by eliminating the ones that are already known and fixed.

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 1, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #13693 ([test] Add coverage to estimaterawfee and estimatesmartfee by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa36aa4

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Aug 2, 2019
fa36aa4 Test: Set -acceptnonstdtxn in feature_fee_estimation (MarcoFalke)
fa1bb53 test: Add -acceptnonstdtxn to self.extra_args[3] (MarcoFalke)
fa8a823 test: Bump rpc_timeout in feature_dbcrash (MarcoFalke)

Pull request description:

  in feature_dbcrash:

  * Fixes bitcoin#16488
  * Fixes bitcoin#16498

  in feature_fee_estimation:

  * Fixes bitcoin#16518

ACKs for top commit:
  fanquake:
    ACK fa36aa4

Tree-SHA512: 9e79a6f954998b196e2a7452f72d2ecf7a6b7f61be610033038e2e40f2feba53e0ee242c7e3cdd94051811e8c96f8ab8031141710da29137fc3acea07cb2dc73
@maflcko maflcko merged commit fa36aa4 into bitcoin:master Aug 2, 2019
@maflcko maflcko deleted the 1907-testRpcTimeoutBump branch August 2, 2019 12:20
@practicalswift
Copy link
Contributor

@MarcoFalke After this merge -- what known test failures remain?

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 3, 2019
fa36aa4 Test: Set -acceptnonstdtxn in feature_fee_estimation (MarcoFalke)
fa1bb53 test: Add -acceptnonstdtxn to self.extra_args[3] (MarcoFalke)
fa8a823 test: Bump rpc_timeout in feature_dbcrash (MarcoFalke)

Pull request description:

  in feature_dbcrash:

  * Fixes bitcoin#16488
  * Fixes bitcoin#16498

  in feature_fee_estimation:

  * Fixes bitcoin#16518

ACKs for top commit:
  fanquake:
    ACK fa36aa4

Tree-SHA512: 9e79a6f954998b196e2a7452f72d2ecf7a6b7f61be610033038e2e40f2feba53e0ee242c7e3cdd94051811e8c96f8ab8031141710da29137fc3acea07cb2dc73
codablock added a commit to codablock/dash that referenced this pull request Jan 4, 2020
This speeds up mempool synchronization a lot due to tricking being forced.
This will later conflict with bitcoin#16493 and bitcoin#16535, but this can
easily be resolved (it does the same).
codablock added a commit to codablock/dash that referenced this pull request Jan 4, 2020
This speeds up mempool synchronization a lot due to trickling being forced.
This will later conflict with bitcoin#16493 and bitcoin#16535, but this can
easily be resolved (it does the same).
UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Jan 4, 2020
This speeds up mempool synchronization a lot due to trickling being forced.
This will later conflict with bitcoin#16493 and bitcoin#16535, but this can
easily be resolved (it does the same).
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 26, 2021
This speeds up mempool synchronization a lot due to trickling being forced.
This will later conflict with bitcoin#16493 and bitcoin#16535, but this can
easily be resolved (it does the same).
kwvg added a commit to kwvg/dash that referenced this pull request Nov 2, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Nov 3, 2021
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants