scripts: remove github-merge.py #16625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
force-pushed
the
remove_github_merge_script
branch
from
c8c1288
to
a83f669
Compare
|
Concept ACK. Also, I can't verify what script a maintainer runs anyway, can only verify the result. So imo it doesn't matter where this script lives. |
|
You should link to the new script in the other repository, for transparency. |
laanwj
reviewed
Aug 19, 2019
laanwj
reviewed
Aug 19, 2019
This script has been moved to the bitcoin-core/bitcoin-maintainer-tools repository, after discussion in a core dev meeting. The rationale being that it is also useful to other projects, and thus should be moved to a more general repository. Meeting log: http://www.erisian.com.au/bitcoin-core-dev/log-2019-08-15.html See also: bitcoin-core/bitcoin-maintainer-tools#28
fanquake
force-pushed
the
remove_github_merge_script
branch
from
a83f669
to
6c27fa0
Compare
|
ACK 6c27fa0 |
laanwj
added a commit
that referenced
this pull request
Aug 19, 2019
6c27fa0 scripts: remove github-merge.py (fanquake) Pull request description: This script has been moved to the bitcoin-core/bitcoin-maintainer-tools repository, after discussion in a core dev meeting. The rationale being that it is also useful to other projects, and thus should be moved to a more general repository. Meeting log: http://www.erisian.com.au/bitcoin-core-dev/log-2019-08-15.html See also: bitcoin-core/bitcoin-maintainer-tools#28 ~~I'll open a follow up PR to port the documentation to the maintainer tools repo.~~ Ported the docs in bitcoin-core/bitcoin-maintainer-tools#29 ACKs for top commit: laanwj: ACK 6c27fa0 Tree-SHA512: 972070c6893043aebe3b62118d2e42d857553202b1eeb9abca55326f580f25e9859de188a1d0c50b9c7d20bdeeddffc00bcf9ad5a76b60add5c8541956d45489
| Needs rebase |
jnewbery
reviewed
Aug 19, 2019
|
|
||
| ### [Verify-Commits](/contrib/verify-commits) ### | ||
| Tool to verify that every merge commit was signed by a developer using the above `github-merge.py` script. | ||
| Tool to verify that every merge commit was signed by a developer using the `github-merge.py` script. |
There was a problem hiding this comment.
nit: s/signed by a developer/signed by a maintainer/
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 19, 2019
6c27fa0 scripts: remove github-merge.py (fanquake) Pull request description: This script has been moved to the bitcoin-core/bitcoin-maintainer-tools repository, after discussion in a core dev meeting. The rationale being that it is also useful to other projects, and thus should be moved to a more general repository. Meeting log: http://www.erisian.com.au/bitcoin-core-dev/log-2019-08-15.html See also: bitcoin-core/bitcoin-maintainer-tools#28 ~~I'll open a follow up PR to port the documentation to the maintainer tools repo.~~ Ported the docs in bitcoin-core/bitcoin-maintainer-tools#29 ACKs for top commit: laanwj: ACK 6c27fa0 Tree-SHA512: 972070c6893043aebe3b62118d2e42d857553202b1eeb9abca55326f580f25e9859de188a1d0c50b9c7d20bdeeddffc00bcf9ad5a76b60add5c8541956d45489
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script has been moved to the bitcoin-core/bitcoin-maintainer-tools repository,
after discussion in a core dev meeting. The rationale being that it is also useful to
other projects, and thus should be moved to a more general repository.
Meeting log: http://www.erisian.com.au/bitcoin-core-dev/log-2019-08-15.html
See also: bitcoin-core/bitcoin-maintainer-tools#28
I'll open a follow up PR to port the documentation to the maintainer tools repo.Ported the docs in bitcoin-core/bitcoin-maintainer-tools#29