ci: Pass down $MAKEJOBS to test_runner.py, other improvements #16739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
promag
reviewed
Aug 27, 2019
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| export LC_ALL=C.UTF-8 | |||
|
|
|||
| mkdir -p "${BASE_SCRATCH_DIR}" | |||
There was a problem hiding this comment.
Is this really necessary? On my system:
$ ls /tmp/this
ls: /tmp/this: No such file or directory
$ CCACHE_DIR=/tmp/this/doesnt/exits ccache find /tmp/this
/tmp/this
/tmp/this/doesnt
/tmp/this/doesnt/exits
/tmp/this/doesnt/exits/9
/tmp/this/doesnt/exits/9/stats
/tmp/this/doesnt/exits/ccache.conf
There was a problem hiding this comment.
Yes, this is needed when the ci runner sets the ccache dir to not reside in the scratch dir. E.g. our cirrus ci:
Line 14 in a7be1cc
There was a problem hiding this comment.
Oh right, when CCACHE_DIR is unrelated to BASE_SCRATCH_DIR, thanks.
fanquake
approved these changes
Aug 29, 2019
laanwj
approved these changes
Aug 29, 2019
laanwj
added a commit
that referenced
this pull request
Aug 29, 2019
…ements fa27372 ci: Move CCACHE_DIR and test_runner tmp dir into ./ci/scratch/ (MarcoFalke) fa60583 ci: Pass down $MAKEJOBS to test_runner.py (MarcoFalke) Pull request description: Some changes to the ci system: * Pass down MAKEJOBS to the test_runner, instead of falling back to the default of 4. Passing it down avoids OOM on weak machines and allows better use of resources on beefy machines. * Move CCACHE_DIR to ./ci/scratch/ subfolder: `ccache` is executed with root permissions inside the docker, so the cache files are created with root as owner. So it might be wise to not put them in the $HOME of the host * Use the scratch dir as prefix for the test runner, as opposed to `/tmp/`, which is often a ramdisk and thus leads to OOM on the host when either a lot of tests are run in parallel or when a lot of tests fail and the datadirs are not cleaned. ACKs for top commit: fanquake: ACK fa27372 laanwj: ACK fa27372 Tree-SHA512: 67834fbab282051ec81c319d460528b32870507e53df2b8a1ce9a1f3f6a685aaf8eb8ba03f5406918ca4a33adf736e6a4adad7134c54cf3a9e47a26c64a13442
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 13, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the ci system:
ccacheis executed with root permissions inside the docker, so the cache files are created with root as owner. So it might be wise to not put them in the $HOME of the host/tmp/, which is often a ramdisk and thus leads to OOM on the host when either a lot of tests are run in parallel or when a lot of tests fail and the datadirs are not cleaned.