gui: remove unnecessary shortcuts in bitcoingui files

[GChuf]

This commit removes 2 shortcuts which are now unnecessary (see new shortcuts which were introduced in 091747b). Also removes some related unnecessary code.

[hebasto]

Concept ACK.

Indeed, Ctrl+Shift+C is replaced by Ctrl+T.
But the Ctrl+Shift+D shortcut is still quite useful, IMO.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

[GChuf]

@hebasto, I'll let other people know what they think about Ctrl+Shift+D - also, do you think it would be better to just use Ctrl+something and not use Shift?

[laanwj]

FWIW: please try to use PR and commit titles that describe your change more precisely. "gui: clean bitcoingui files" doesn't convey much information.

[GChuf]

Renamed, hopefully the title is clearer now.

[laanwj]

Renamed, hopefully the title is clearer now.

Yes, thanks!

[GChuf]

Squashed and decided to keep the showDebugWindow shortcut as per hebasto's opinion.

[hebasto]

ACK f0fbb0d, tested on Linux Mint 19.2:

• Ctrl+Shift+C - does nothing
• Ctrl+{I|T|N|P} - behavior is unchanged

[luke-jr]

Concept NACK: Unless there's a reason to, we shouldn't break existing shortcuts...

[GChuf]

@luke-jr the reasons are all explained if you would just read them

[luke-jr]

I see no reasons given. An additional shortcut key does not in any way justify removal of the existing one.

[jonasschnelli]

Tend to NACK.
IMO there is no harm in keeping the "old" one (and I expect there are users using this shortcut heavily).