Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: speed up wallet_avoidreuse, add logging #17362

Merged
merged 2 commits into from Nov 7, 2019
Merged

test: speed up wallet_avoidreuse, add logging #17362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d50b26
test: add logging to wallet_avoidreuse.py
jonatack Nov 4, 2019
0e7c90e
test: speed up wallet_avoidreuse.py
jonatack Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/functional/wallet_avoidreuse.py
View file
Open in desktop
Expand Up @@ -68,6 +68,9 @@ class AvoidReuseTest(BitcoinTestFramework):
def set_test_params(self):
self.setup_clean_chain = False
self.num_nodes = 2
# This test isn't testing txn relay/timing, so set whitelist on the
# peers for instant txn relay. This speeds up the test run time 2-3x.
self.extra_args = [["-whitelist=127.0.0.1"]] * self.num_nodes

def skip_test_if_missing_module(self):
self.skip_if_no_wallet()
Expand All @@ -87,6 +90,8 @@ def run_test(self):

def test_persistence(self):
'''Test that wallet files persist the avoid_reuse flag.'''
self.log.info("Test wallet files persist avoid_reuse flag")
jonatack marked this conversation as resolved.
Show resolved Hide resolved

# Configure node 1 to use avoid_reuse
self.nodes[1].setwalletflag('avoid_reuse')

Expand All @@ -109,6 +114,8 @@ def test_persistence(self):

def test_immutable(self):
'''Test immutable wallet flags'''
self.log.info("Test immutable wallet flags")

# Attempt to set the disable_private_keys flag; this should not work
assert_raises_rpc_error(-8, "Wallet flag is immutable", self.nodes[1].setwalletflag, 'disable_private_keys')

Expand All @@ -130,6 +137,7 @@ def test_fund_send_fund_senddirty(self):
the avoid_reuse flag set to false. This means the 10 BTC send should succeed,
where it fails in test_fund_send_fund_send.
'''
self.log.info("Test fund send fund send dirty")

fundaddr = self.nodes[1].getnewaddress()
retaddr = self.nodes[0].getnewaddress()
Expand Down Expand Up @@ -183,6 +191,7 @@ def test_fund_send_fund_send(self):
[1] tries to spend 10 BTC (fails; dirty).
[1] tries to spend 4 BTC (succeeds; change address sufficient)
'''
self.log.info("Test fund send fund send")

fundaddr = self.nodes[1].getnewaddress()
retaddr = self.nodes[0].getnewaddress()
Expand Down