Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: remove unused variable spk_man in import* RPCs #17377

Commits on Nov 5, 2019

  1. wallet: remove unused variable spk_man in import* RPCs

    Each of the following RPC functions define a variable reference
    "LegacyScriptPubKeyMan& spk_man" which is not used, leading to compiler
    warnings:
    - importprivkey
    - importaddress
    - importpubkey
    - importwallet
    - importmulti
    
    The call to GetLegacyScriptPubKeyMan() still serves the purpose to throw an
    error if the wallet doesn't have a LegacyScriptPubKeyMan instance. This commit
    introduces a new function RequireLegacyScriptPubKeyMan() which in turn calls
    GetLegacyScriptPubKeyMan() but discards its return value.
    theStack committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    606422b View commit details
    Browse the repository at this point in the history