tests: Update valgrind suppressions

[practicalswift]

Update valgrind suppressions.

To test this PR:

$ valgrind --suppressions=contrib/valgrind.supp src/test/test_bitcoin
$ valgrind --suppressions=contrib/valgrind.supp src/bench/bench_bitcoin -evals=1 \
      -scaling=0.0

[maflcko]

Some notes:

• Would be nice to explain how to generate suppressions
• Does it make sense to move it to ./test, like the other suppressions?
• Does the list depend on OS/library versions?

I get these errors:

$ valgrind --leak-check=full --show-reachable=yes --error-limit=no --gen-suppressions=all --suppressions=./contrib/valgrind.supp  ./src/test/test_bitcoin -t merkle_tests 
==32499== Memcheck, a memory error detector
==32499== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==32499== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==32499== Command: ./src/test/test_bitcoin -t merkle_tests
==32499== 
Running 6 test cases...
==32499== Conditional jump or move depends on uninitialised value(s)
==32499==    at 0x48806CD: boost::filesystem::detail::directory_iterator_increment(boost::filesystem::directory_iterator&, boost::system::error_code*) (in /usr/lib64/libboost_filesystem.so.1.69.0)
==32499==    by 0x4880D0A: boost::filesystem::detail::directory_iterator_construct(boost::filesystem::directory_iterator&, boost::filesystem::path const&, boost::system::error_code*) (in /usr/lib64/libboost_filesystem.so.1.69.0)
==32499==    by 0x48814D6: ??? (in /usr/lib64/libboost_filesystem.so.1.69.0)
==32499==    by 0x488181E: boost::filesystem::detail::remove_all(boost::filesystem::path const&, boost::system::error_code*) (in /usr/lib64/libboost_filesystem.so.1.69.0)
==32499==    by 0x27CA1F: remove_all (operations.hpp:673)
==32499==    by 0x27CA1F: BasicTestingSetup::~BasicTestingSetup() (setup_common.cpp:93)
==32499==    by 0x27EBF1: TestingSetup::~TestingSetup() (setup_common.cpp:138)
==32499==    by 0x425CC7: ~merkle_test (merkle_tests.cpp:183)
==32499==    by 0x425CC7: merkle_tests::merkle_test_invoker() (merkle_tests.cpp:183)
==32499==    by 0x4920581: ??? (in /usr/lib64/libboost_unit_test_framework.so.1.69.0)
==32499==    by 0x491F5EC: boost::execution_monitor::catch_signals(boost::function<int ()> const&) (in /usr/lib64/libboost_unit_test_framework.so.1.69.0)
==32499==    by 0x491F677: boost::execution_monitor::execute(boost::function<int ()> const&) (in /usr/lib64/libboost_unit_test_framework.so.1.69.0)
==32499==    by 0x491F74D: boost::execution_monitor::vexecute(boost::function<void ()> const&) (in /usr/lib64/libboost_unit_test_framework.so.1.69.0)
==32499==    by 0x494A24E: boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned int) (in /usr/lib64/libboost_unit_test_framework.so.1.69.0)
==32499== 
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:_ZN5boost10filesystem6detail28directory_iterator_incrementERNS0_18directory_iteratorEPNS_6system10error_codeE
   fun:_ZN5boost10filesystem6detail28directory_iterator_constructERNS0_18directory_iteratorERKNS0_4pathEPNS_6system10error_codeE
   obj:/usr/lib64/libboost_filesystem.so.1.69.0
   fun:_ZN5boost10filesystem6detail10remove_allERKNS0_4pathEPNS_6system10error_codeE
   fun:remove_all
   fun:_ZN17BasicTestingSetupD1Ev
   fun:_ZN12TestingSetupD1Ev
   fun:~merkle_test
   fun:_ZN12merkle_testsL19merkle_test_invokerEv
   obj:/usr/lib64/libboost_unit_test_framework.so.1.69.0
   fun:_ZN5boost17execution_monitor13catch_signalsERKNS_8functionIFivEEE
   fun:_ZN5boost17execution_monitor7executeERKNS_8functionIFivEEE
   fun:_ZN5boost17execution_monitor8vexecuteERKNS_8functionIFvvEEE
   fun:_ZN5boost9unit_test19unit_test_monitor_t21execute_and_translateERKNS_8functionIFvvEEEj
}
...

[maflcko]

Oh, and for a follow-up: The leveldb suppressions should be removed after #17398

[practicalswift]

@MarcoFalke Could you re-run …

$ valgrind --suppressions=contrib/valgrind.supp src/test/test_bitcoin
$ valgrind --suppressions=contrib/valgrind.supp src/bench/bench_bitcoin -evals=1 \
      -scaling=0.0

… on your system with the updated suppressions and see if it passes without warnings? :)

[practicalswift]

• Would be nice to explain how to generate suppressions

Documentation added.

• Does it make sense to move it to ./test, like the other suppressions?

Sure! Do you have any suggestion on where under test/ to put it?

• Does the list depend on OS/library versions?

Documentation added.

I get these errors:

Suppressions added.