tests: Enable tests which are incorrectly skipped when running test_runner.py --usecli

[practicalswift]

Annotate functional tests supporting bitcoin-cli (--usecli) as such.

Prior to this commit 74 tests were unnecessarily skipped when running test_runner.py --usecli.

Before:

$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
    grep -E ' (Passed|Skipped) *$' | sort | uniq -c
      9  ✓ Passed
    126  ○ Skipped

After:

$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
    grep -E ' (Passed|Skipped) *$' | sort | uniq -c
     83  ✓ Passed
     52  ○ Skipped

Context: --usecli was introduced in f6ade9c

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #17631 (Expose block filters over REST. by TheBlueMatt)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[laanwj]

Why do some tests not support --cli?
(and wouldn't it be less hassle to mark those? with the idea of fixing them later, maybe)

[practicalswift]

Why do some tests not support --cli?

The reasons varies but the most common exception raised is TypeError: Object of type 'Decimal' is not JSON serializable. There is also OSError: [Errno 7] Argument list too long: 'bitcoin-cli' and a few others.

(and wouldn't it be less hassle to mark those? with the idea of fixing them later, maybe)

Good point! Now updated: that brought down the net diff from +80 to +45 (+50-5).

Please re-review :)

[fanquake]

You could also update rpc_deriveaddresses.py which has self.supports_cli = 1.

[practicalswift]

@fanquake Good catch. Now updated. Please re-review :)

[laanwj]

Code review ACK 5ac804a

TypeError: Object of type 'Decimal' is not JSON serializable

That one should be pretty easy to fix by adding default=EncodeDecimal to json.dumps as done in functional/test_framework/authproxy.py

(no need to do so here, though)