Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Add MACHO dylib checks to symbol-check.py #17863

Merged
merged 2 commits into from Jan 22, 2020

Commits on Jan 4, 2020

  1. scripts: fix check-symbols & check-security argument passing

    The first argument in bin_PROGRAMS (bitcoind) was being silently
    dropped and never passed into the check-security.py or check-symbols.py scripts.
    
    This has been the case since the scripts were added to the makefile in
    bitcoin@f3d3eaf.
    
    Example of the behavior:
    
    ```python
    # touch a, touch b, touch c
    # python3 args.py < a b c
    
    import sys
    if __name__ == '__main__':
        print(sys.argv)
        # ['args.py', 'b', 'c']
    
        # if you add some lines to "a",
        # you'll see them here..
        for line in sys.stdin:
            print(line)
    ```
    fanquake committed Jan 4, 2020
    Copy the full SHA
    76bf972 View commit details
    Browse the repository at this point in the history
  2. 1
    Copy the full SHA
    c491368 View commit details
    Browse the repository at this point in the history