Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ThreadDumpAddresses with a timer. #1787

Closed
wants to merge 2 commits into from

Conversation

jgarzik
Copy link
Contributor

@jgarzik jgarzik commented Sep 5, 2012

Wanted to eliminate a silly thread that does nothing but waste system resources as a poor man's cron.

boost.asio also has deadline_timer, which is worth investigating.

@jgarzik
Copy link
Contributor Author

jgarzik commented Sep 5, 2012

Note not intended for 0.7.

@laanwj
Copy link
Member

laanwj commented Sep 6, 2012

Investigating boost.asio sounds like a good idea, before we build it entirely from scratch.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5cb618146cedc7630513afb016ef386e6bd4f172 for binaries and test log.

@sipa
Copy link
Member

sipa commented Sep 28, 2012

Looks like a lot of code for a feature that should be standard. I assume it will be easier using boost::asio?

@jgarzik
Copy link
Contributor Author

jgarzik commented Sep 28, 2012

Most likely we can use boost.asio deadline_timer... but that requires moving the "io_service" from RPC into the core code, so that non-RPC code may take advantage of the async I/O engine (and the timers that lie within).

@luke-jr
Copy link
Member

luke-jr commented Nov 13, 2012

Needs rebase.

@jgarzik
Copy link
Contributor Author

jgarzik commented Nov 16, 2012

closing, self-meh.

should consider boost deadline timer, rather than creating threads for same.

@jgarzik jgarzik closed this Nov 16, 2012
@jgarzik jgarzik deleted the timer branch August 24, 2014 04:19
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants