build: remove double LIBBITCOIN_SERVER linking #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Is it a result of #15638 ? |
Gitian builds
|
|
ACK 831e122. |
|
ACK 831e122 |
|
good catch, I'm happy that this is no longer needed! |
laanwj
added a commit
that referenced
this pull request
Jan 13, 2020
831e122 build: remove double LIBBITCOIN_SERVER linking (fanquake) Pull request description: Seems that this is no longer required. Have tested building on macOS and Debian. ACKs for top commit: promag: ACK 831e122. practicalswift: ACK 831e122 laanwj: ACK 831e122 Tree-SHA512: d226d9fa0292189fae7e2af14781a511c3633f1352324f19ae642e941d06c34e2abf8b1df97d2330d76dba6024a93d8d341e02cc4882d7066f97e82585631fe1
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Jan 21, 2020
This was referenced Mar 18, 2020
fanquake
added a commit
that referenced
this pull request
Mar 26, 2020
1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to #17910 Originally, this PR was part of #18377, which later got replaced by a better one #18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK 1f97b69 theStack: ACK 1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 28, 2020
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Nov 1, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
…h-Makefile 1f97b69 build: remove double LIBBITCOIN_SERVER from bench-Makefile (Harris) Pull request description: This PR removes the redundant **LIBBITCOIN_SERVER** linking from bench's Makefile. This PR is similar to bitcoin#17910 Originally, this PR was part of bitcoin#18377, which later got replaced by a better one bitcoin#18397 written by **hebasto**. ACKs for top commit: Empact: Code Review ACK bitcoin@1f97b69 theStack: ACK bitcoin@1f97b69 hebasto: ACK 1f97b69 Tree-SHA512: e43035262361d4458a7dcfc920445540f19301387814cde1be0539c936fc20da0dcbe49e5ea25385e6d36d9639515b7a4171228223da568d93427e9c32810945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that this is no longer required. Have tested building on macOS and Debian.