Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing #include to fix compiler errors #17980

Merged
merged 1 commit into from Jan 22, 2020
Merged

test: add missing #include to fix compiler errors #17980

merged 1 commit into from Jan 22, 2020

Conversation

kallewoof
Copy link
Member

@kallewoof kallewoof commented Jan 22, 2020 •
edited

I believe this fixes AppVeyor errors in master. Will close if that is not the case.

Closes #17976

@fanquake fanquake added the Tests label Jan 22, 2020
fanquake
fanquake approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a5a2654 - glad the fix turned out to be this simple.

fanquake added a commit that referenced this pull request Jan 22, 2020
@fanquake
Merge #17980: test: add missing #include to fix compiler errors
e45463a 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes #17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
@fanquake fanquake merged commit a5a2654 into bitcoin:master Jan 22, 2020
@kallewoof kallewoof deleted the 200122-tests-cuckoo-dequeue branch January 22, 2020 09:27
@practicalswift
Copy link
Contributor

ACK a5a2654

Thanks a lot @kallewoof!

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 23, 2020
@kallewoof @fanquake
test: add missing #include to fix compiler errors
daf2fff 
Github-Pull: bitcoin#17980
Rebased-From: a5a2654
@fanquake
Copy link
Member

Added this for backporting in 17988 to fix Appveyor.

@fanquake fanquake mentioned this pull request Jan 23, 2020
Merged
laanwj added a commit that referenced this pull request Jan 23, 2020
@laanwj
Merge #17988: [0.19] Final backports for 0.19.1
178a834 
daf2fff test: add missing #include to fix compiler errors (Karl-Johan Alm)
c8ad23c bug-fix macos: give free bytes to F_PREALLOCATE (Karl-Johan Alm)

Pull request description:

  We're about ready to do a [0.19.1 release](https://github.com/bitcoin/bitcoin/milestone/44); so I've opened this to collect the last remaining backports.

  If there's something that's been missed / or isn't tagged ["Needs backport (0.19)"](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+label%3A%22Needs+backport+%280.19%29%22) that you think should be, please comment.

  Currently backports:
  * #17887 - bug-fix macos: give free bytes to F_PREALLOCATE
  * #17980 - test: add missing #include to fix compiler errors

ACKs for top commit:
  laanwj:
    ACK daf2fff

Tree-SHA512: 8438f992d0c39315a4da4c3f8ab5c92acefada4b0ba5a5cec3775dea2541492d386bf4e7c9e76e1494a6d4cf16a9205287d27ffd23d9c3056f213d733605eeee
@sipsorcery sipsorcery mentioned this pull request Jan 26, 2020
Merged
4 tasks
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Feb 13, 2020
@MarkLTZ
Bitcoin backports:
d99bc96 
- [0.19] wallet: Reset reused transactions cache bitcoin#18083
- 0.19: Backports bitcoin#17792
- psbt: handle unspendable psbts bitcoin#17524
- qt: Fix comparison function signature bitcoin#17634
- psbt: check that various indexes and amounts are within bounds bitcoin#17156
- [0.19] psbt: check that various indexes and amounts are within bounds bitcoin#18079
- [0.19] Final backports for 0.19.1 bitcoin#17988
- Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash bitcoin#17924
- qt: Fix deprecated QCharRef usage bitcoin#18101
- gui: Throttle GUI update pace when -reindex bitcoin#18121
- gui: Fix race in WalletModel::pollBalanceChanged bitcoin#18123
- gui: Fix unintialized WalletView::progressDialog bitcoin#18062
- Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open bitcoin#18007
- bug-fix macos: give free bytes to F_PREALLOCATE bitcoin#17887
- test: add missing #include to fix compiler errors bitcoin#17980
- zmq: Fix due to invalid argument and multiple notifiers bitcoin#17445
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
175ea9b 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
488e666 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
451cc41 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
9feb0f2 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
bc7867e 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 14, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
867c468 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 14, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
30a5b5f 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17980: test: add missing #include to fix compiler errors
25f3f66 
a5a2654 test: add missing #include to fix compiler errors (Karl-Johan Alm)

Pull request description:

  I believe this fixes AppVeyor errors in master. Will close if that is not the case.

  Closes bitcoin#17976

ACKs for top commit:
  fanquake:
    ACK a5a2654 - glad the fix turned out to be this simple.

Tree-SHA512: 8fed8c2050d0f435e7ed6db1c2927d5daccc3540c6cf9e57e644d0931a740359550a5270201c893f40200960101f11cd039d807d4ed0190f1e0c674f86fd7290
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Aug 24, 2021
@kallewoof @PiRK
test: add missing #include
ee44514 
Summary: This is a backport of [[bitcoin/bitcoin#17980 | core#17980]]

Test Plan: `ninja`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9904
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 9, 2021
@laanwj @Munkybooty
Merge bitcoin#17988: [0.19] Final backports for 0.19.1
2b9bf6c 
daf2fff test: add missing #include to fix compiler errors (Karl-Johan Alm)
c8ad23c bug-fix macos: give free bytes to F_PREALLOCATE (Karl-Johan Alm)

Pull request description:

  We're about ready to do a [0.19.1 release](https://github.com/bitcoin/bitcoin/milestone/44); so I've opened this to collect the last remaining backports.

  If there's something that's been missed / or isn't tagged ["Needs backport (0.19)"](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+label%3A%22Needs+backport+%280.19%29%22) that you think should be, please comment.

  Currently backports:
  * bitcoin#17887 - bug-fix macos: give free bytes to F_PREALLOCATE
  * bitcoin#17980 - test: add missing #include to fix compiler errors

ACKs for top commit:
  laanwj:
    ACK daf2fff

Tree-SHA512: 8438f992d0c39315a4da4c3f8ab5c92acefada4b0ba5a5cec3775dea2541492d386bf4e7c9e76e1494a6d4cf16a9205287d27ffd23d9c3056f213d733605eeee
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 9, 2021
@laanwj @Munkybooty
Merge bitcoin#17988: [0.19] Final backports for 0.19.1
5da2a64 
daf2fff test: add missing #include to fix compiler errors (Karl-Johan Alm)
c8ad23c bug-fix macos: give free bytes to F_PREALLOCATE (Karl-Johan Alm)

Pull request description:

  We're about ready to do a [0.19.1 release](https://github.com/bitcoin/bitcoin/milestone/44); so I've opened this to collect the last remaining backports.

  If there's something that's been missed / or isn't tagged ["Needs backport (0.19)"](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+label%3A%22Needs+backport+%280.19%29%22) that you think should be, please comment.

  Currently backports:
  * bitcoin#17887 - bug-fix macos: give free bytes to F_PREALLOCATE
  * bitcoin#17980 - test: add missing #include to fix compiler errors

ACKs for top commit:
  laanwj:
    ACK daf2fff

Tree-SHA512: 8438f992d0c39315a4da4c3f8ab5c92acefada4b0ba5a5cec3775dea2541492d386bf4e7c9e76e1494a6d4cf16a9205287d27ffd23d9c3056f213d733605eeee
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 9, 2021
@laanwj @Munkybooty
Merge bitcoin#17988: [0.19] Final backports for 0.19.1
7ac5a41 
daf2fff test: add missing #include to fix compiler errors (Karl-Johan Alm)
c8ad23c bug-fix macos: give free bytes to F_PREALLOCATE (Karl-Johan Alm)

Pull request description:

  We're about ready to do a [0.19.1 release](https://github.com/bitcoin/bitcoin/milestone/44); so I've opened this to collect the last remaining backports.

  If there's something that's been missed / or isn't tagged ["Needs backport (0.19)"](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+label%3A%22Needs+backport+%280.19%29%22) that you think should be, please comment.

  Currently backports:
  * bitcoin#17887 - bug-fix macos: give free bytes to F_PREALLOCATE
  * bitcoin#17980 - test: add missing #include to fix compiler errors

ACKs for top commit:
  laanwj:
    ACK daf2fff

Tree-SHA512: 8438f992d0c39315a4da4c3f8ab5c92acefada4b0ba5a5cec3775dea2541492d386bf4e7c9e76e1494a6d4cf16a9205287d27ffd23d9c3056f213d733605eeee
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 23, 2021
@laanwj @Munkybooty
Merge bitcoin#17988: [0.19] Final backports for 0.19.1
1d79da9 
daf2fff test: add missing #include to fix compiler errors (Karl-Johan Alm)
c8ad23c bug-fix macos: give free bytes to F_PREALLOCATE (Karl-Johan Alm)

Pull request description:

  We're about ready to do a [0.19.1 release](https://github.com/bitcoin/bitcoin/milestone/44); so I've opened this to collect the last remaining backports.

  If there's something that's been missed / or isn't tagged ["Needs backport (0.19)"](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+label%3A%22Needs+backport+%280.19%29%22) that you think should be, please comment.

  Currently backports:
  * bitcoin#17887 - bug-fix macos: give free bytes to F_PREALLOCATE
  * bitcoin#17980 - test: add missing #include to fix compiler errors

ACKs for top commit:
  laanwj:
    ACK daf2fff

Tree-SHA512: 8438f992d0c39315a4da4c3f8ab5c92acefada4b0ba5a5cec3775dea2541492d386bf4e7c9e76e1494a6d4cf16a9205287d27ffd23d9c3056f213d733605eeee
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appveyor ci fails again
3 participants
@kallewoof @practicalswift @fanquake