Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followups from #16681 #18068

Closed
fanquake opened this issue Feb 5, 2020 · 0 comments · Fixed by #18069
Closed

Followups from #16681 #18068

fanquake opened this issue Feb 5, 2020 · 0 comments · Fixed by #18069
Labels
good first issue Tests

Comments

@fanquake
Copy link
Member

fanquake commented Feb 5, 2020

#16681 was merged, and there are a couple usage of 'regtest' leftover in the functional tests.

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.
@fanquake fanquake mentioned this issue Feb 5, 2020
Merged
@theStack theStack mentioned this issue Feb 5, 2020
Merged
@maflcko maflcko closed this as completed in bd5c4c6 Feb 5, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 17, 2022
@PastaPastaPasta
Merge bitcoin#18069: test: replace 'regtest' leftovers by self.chain
ea1c235 
eca56f8 test: replace 'regtest' leftovers by self.chain (Sebastian Falbesoner)

Pull request description:

  This is a follow-up PR to bitcoin#16681 (fixes bitcoin#18068), replacing all remaining hardcoded `"regtest"` strings in functional tests by `self.chain`.

Top commit has no ACKs.

Tree-SHA512: 96524649b33164938e5a95215991103ed7855ebab55ef788d4816b3fa5cbc03d8f3b0d39f2247a87522f289fd7f4daf25e059900b8462b5127eb154bbee89054
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Aug 30, 2022
@PastaPastaPasta
Merge bitcoin#18069: test: replace 'regtest' leftovers by self.chain
be35f1b 
eca56f8 test: replace 'regtest' leftovers by self.chain (Sebastian Falbesoner)

Pull request description:

  This is a follow-up PR to bitcoin#16681 (fixes bitcoin#18068), replacing all remaining hardcoded `"regtest"` strings in functional tests by `self.chain`.

Top commit has no ACKs.

Tree-SHA512: 96524649b33164938e5a95215991103ed7855ebab55ef788d4816b3fa5cbc03d8f3b0d39f2247a87522f289fd7f4daf25e059900b8462b5127eb154bbee89054
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: replace 'regtest' leftovers by self.chain theStack/bitcoin
1 participant
@fanquake