Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor / optimizations: feebumper #18146

Closed
wants to merge 1 commit into from
Closed

refactor / optimizations: feebumper #18146

wants to merge 1 commit into from

Conversation

sanjaykdragon
Copy link
Contributor

Minor optimization - stop calling GetHash so much

Minor optimization - stop calling GetHash so much
@theStack
Copy link
Contributor

Both CWalletTx::GetHash() and CTransaction::GetHash() are just simple getter-methods returning the value of a member variable (i.e. not computing anything) and both of them are implemented in their header files, enabling inlining, hence I highly doubt that this is bringing any performance improvement.

@sanjaykdragon
Copy link
Contributor Author

Both CWalletTx::GetHash() and CTransaction::GetHash() are just simple getter-methods returning the value of a member variable (i.e. not computing anything) and both of them are implemented in their header files, enabling inlining, hence I highly doubt that this is bringing any performance improvement.

Didn't know that, thought that GetHash did some computations

@sanjaykdragon sanjaykdragon deleted the patch-1 branch February 14, 2020 16:06
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants