Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Correct spelling errors in comments #18253

Merged
merged 1 commit into from Mar 4, 2020

Conversation

Empact
Copy link
Member

@Empact Empact commented Mar 3, 2020

And ci script output.

Identified via test/lint/lint-spelling

Before:

$ test/lint/lint-spelling.sh 
ci/test/05_before_script.sh:29: explicitely  ==> explicitly
src/compressor.h:43: Ser  ==> Set
src/compressor.h:78: Ser  ==> Set
src/logging/timer.h:88: outputing  ==> outputting
src/node/psbt.cpp:87: minumum  ==> minimum
src/qt/coincontroldialog.cpp:372: UnSelect  ==> deselect
src/qt/coincontroldialog.cpp:443: unselect  ==> deselect
src/qt/coincontroldialog.cpp:448: UnSelect  ==> deselect
src/qt/coincontroldialog.cpp:699: UnSelect  ==> deselect
src/serialize.h:211: Ser  ==> Set
src/serialize.h:213: Ser  ==> Set
src/serialize.h:228: Ser  ==> Set
src/serialize.h:246: Ser  ==> Set
src/serialize.h:484: Ser  ==> Set
src/serialize.h:490: Ser  ==> Set
src/serialize.h:510: Ser  ==> Set
src/serialize.h:622: Ser  ==> Set
src/serialize.h:740: Ser  ==> Set
src/test/base32_tests.cpp:14: fo  ==> of, for
src/test/base64_tests.cpp:14: fo  ==> of, for
src/txmempool.h:756: incomaptible  ==> incompatible
src/undo.h:26: Ser  ==> Set
src/wallet/coincontrol.h:74: UnSelect  ==> deselect
test/functional/feature_backwards_compatibility.py:116: Abondon  ==> Abandon
test/functional/rpc_getaddressinfo_label_deprecation.py:7: superceded  ==> superseded
test/lint/lint-shell.sh:44: desriptor  ==> descriptor
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

After:

$ test/lint/lint-spelling.sh 
src/test/base32_tests.cpp:14: fo  ==> of, for
src/test/base64_tests.cpp:14: fo  ==> of, for
test/functional/rpc_getaddressinfo_label_deprecation.py:7: superceded  ==> superseded
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

And ci script output.

Identified via test/lint/lint-spelling
@maflcko
Copy link
Member

maflcko commented Mar 3, 2020

ACK 9b0e162

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 3, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

ACK 9b0e162

@fanquake fanquake merged commit 0886042 into bitcoin:master Mar 4, 2020
@Empact Empact deleted the 2020-03-lint-spelling branch March 4, 2020 05:01
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants