Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Import only required Objective-C headers #18400

Closed
wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 21, 2020

AppKit/AppKit.h, Cocoa/Cocoa.h and Foundation/Foundation.h are just bundles of other headers.

With this PR only required headers are imported.

@DrahtBot DrahtBot added the GUI label Mar 21, 2020
@fanquake fanquake added the macOS label Mar 21, 2020
@maflcko maflcko changed the title Import only required Objective-C headers gui: Import only required Objective-C headers Mar 22, 2020
@laanwj
Copy link
Member

laanwj commented Mar 25, 2020

~0 on this, maybe this is better out of principle, but I don't think headers included in one file significantly affect compile time or memory use.

Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @laanwj, the less platform specific code the better, and the savings aren't worth.

@hebasto hebasto closed this Apr 10, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants