doc: block-relay-only vs blocksonly #18464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Mar 29, 2020
maflcko
force-pushed
the
2003-docBlockRelayOnly
branch
from
fa75475
to
fae5d88
Compare
|
Addressed feedback by @jonatack |
|
ACK fae5d88 |
hebasto
reviewed
Mar 30, 2020
Co-Authored-By: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
maflcko
force-pushed
the
2003-docBlockRelayOnly
branch
from
080eff6
to
fa6e01f
Compare
hebasto
approved these changes
Mar 30, 2020
|
ACK fa6e01f pico-nit: as the outbound peer connections are called "full-relay" and "block-relay" in the debug log, perhaps use "block-relay" rather than "block-relay-only". Though the code comments use block-relay-only, the -only seems redundant, though I may be saying that out of habit of seeing "block-relay" in the log. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 3, 2020
fa6e01f doc: block-relay-only is not blocksonly (MarcoFalke) Pull request description: Those are different concepts, see https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.19.0.1.md#p2p-changes for the block-relay-only nodes. ACKs for top commit: jonatack: ACK fa6e01f hebasto: ACK fa6e01f Tree-SHA512: 6de2c81201b62ed59e504a3a6f164068600182e1bbf63eda7f9db3160507bdba091c13882ee0e75e713f0832bfaf5973a86eba3b94588d5b72196f05ae0a9c9a
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 14, 2021
Summary: > When -blocksonly is set to 1, it interacts with the -walletbroadcast > parameter and sets it to 0 if it has not been set already.This behavior > is not captured by the current documentation, which claims that -blocksonly > does not impact any wallet transactions. > > Update the max number of outgoing peers from 8 to 10, due to the > addition of two -blocksonly peers. This is a backport of Core [[bitcoin/bitcoin#18391 | PR18391]] and [[bitcoin/bitcoin#18464 | PR18464]] Test Plan: `ninja && src/bitcoind -help` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8894
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are different concepts, see https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.19.0.1.md#p2p-changes for the block-relay-only nodes.