When encrypting the wallet, warn user that he should make new backups. A fix for Issue #1884.

[runeksvendsen]

No description provided.

[Diapolo]

Idea is a good one, what I would love to see is avoid HTML-format tags in strings we use in translations. This is not always possible, but I would split that mega string into smaller pieces and use e.g. + QString("<br>") + or + "<br>" + in between.

Edit: What does the <qt> tag do or achieve there?

[laanwj]

No comment on the message, though I'd indeed suggest splitting it over multiple lines in the source code for readability.

The <qt> tag marks the text as rich text (for Qt::AutoText). It is not always necessary, but it's safe.

[runeksvendsen]

Good point about HTML in translation strings. I've removed the tags from the strings in tr(). And also made it somewhat more readable.

I'm wondering if we should include a more detailed description in the message, as previous backups don't exactly become useless as soon as the wallet is encrypted. Only when the user starts sending transactions, and the change is received by the encrypted addresses. But I figure it might just be better to not include that technicality.

[laanwj]

Personally I'd use this syntax to spread the message over multiple lines, ie surround every line with ":

        tr("Bitcoin will close now to finish the encryption process. "
        "Remember that encrypting your wallet cannot fully protect "
        "..."
        ...)

With the current way, all the indentation whitespace ends up in the translation string.

[runeksvendsen]

You're right. That does look better. I didn't know tr() accepts multiple arguments like that.

[laanwj]

ACK, please squash into one commit

[BitcoinPullTester]

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/1bf66fcc0aaf0bd12bbb1d1026d52b6388033d38 for binaries and test log.

This could happen for one of several reasons:

1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
3. The test suite fails on either Linux i386 or Win32
4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

[runeksvendsen]

Cool that we have an automatic build and test bot!

I don't quite get the error though:

+ cp bitcoind test_bitcoin out/
+ git apply /mnt/test-scripts/bitcoind-comparison.patch
error: patch failed: src/main.cpp:2368
error: src/main.cpp: patch does not apply

since this patch doesn't touch main.cpp.