test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field] #19188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
maflcko
changed the title
|
Can be tested by reverting the fix and observing the warning: |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2006-testNoShadowField
branch
from
fad2ff1
to
fac6b9b
Compare
|
Concept ACK. |
|
ACK fac6b9b -- patch looks correct |
fanquake
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
ACK fac6b9b - Warnings compiling fa16e78 are below. No warnings with fac6b9b. The -Wshadow-field diagnostic has been available in Clang since 5.0.0. It's not available for GCC.
In file included from wallet/test/wallet_test_fixture.cpp:5:
./wallet/test/wallet_test_fixture.h:22:17: warning: non-static data member 'm_node' of 'WalletTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
1 warning generated.
....
In file included from wallet/test/init_test_fixture.cpp:8:
./wallet/test/init_test_fixture.h:21:17: warning: non-static data member 'm_node' of 'InitWalletDirTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
1 warning generated.
...
In file included from wallet/test/wallet_test_fixture.cpp:5:
./wallet/test/wallet_test_fixture.h:22:17: warning: non-static data member 'm_node' of 'WalletTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
1 warning generated.
...
In file included from wallet/test/init_tests.cpp:11:
./wallet/test/init_test_fixture.h:21:17: warning: non-static data member 'm_node' of 'InitWalletDirTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
1 warning generated.
CXX test/util/libtest_util_a-mining.o
CXX test/util/libtest_util_a-net.o
In file included from wallet/test/psbt_wallet_tests.cpp:12:
./wallet/test/wallet_test_fixture.h:22:17: warning: non-static data member 'm_node' of 'WalletTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
1 warning generated.
CXX test/util/libtest_util_a-setup_common.o
CXX test/util/libtest_util_a-str.o
CXX test/util/libtest_util_a-transaction_utils.o
CXX test/util/libtest_util_a-wallet.o
CXX bench/bench_bitcoin-addrman.o
CXX bench/bench_bitcoin-bench_bitcoin.o
CXX bench/bench_bitcoin-bench.o
CXX bench/bench_bitcoin-block_assemble.o
CXX bench/bench_bitcoin-checkblock.o
In file included from wallet/test/coinselector_tests.cpp:12:
./wallet/test/wallet_test_fixture.h:22:17: warning: non-static data member 'm_node' of 'WalletTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
1 warning generated.
CXX bench/bench_bitcoin-checkqueue.o
In file included from wallet/test/wallet_tests.cpp:22:
./wallet/test/wallet_test_fixture.h:22:17: warning: non-static data member 'm_node' of 'WalletTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
wallet/test/wallet_tests.cpp:538:17: warning: non-static data member 'm_node' of 'ListCoinsTestingSetup' shadows member inherited from type 'BasicTestingSetup' [-Wshadow-field]
NodeContext m_node;
^
./test/util/setup_common.h:76:17: note: declared here
NodeContext m_node;
^
2 warnings generated.
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 8, 2020
…e testing setup [-Wshadow-field] Summary: ~~NodeContext m_node is already a member of BasicTestingSetup which WalletTestingSetup inherits from via TestingSetup~~ Turns out Core had done this Backport of Core [[bitcoin/bitcoin#19188 | PR19188]] Test Plan: ninja check-all Reviewers: #bitcoin_abc, Fabien, deadalnix Reviewed By: #bitcoin_abc, Fabien, deadalnix Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D6835
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this warning will eliminate unexpected test failures and hard to review code. Moreover, there shouldn't be a use case in Bitcoin Core that relies on fields to be shadowed.