refactor: Drop ::HasWallets() #19261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
2020-06-drop-has-wallets
branch
from
d85c6da
to
ccf1f6e
Compare
hebasto
reviewed
Jun 13, 2020
|
ACK ccf1f6e |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 14, 2020
ccf1f6e refactor: Drop ::HasWallets() (João Barbosa) Pull request description: Minor follow-up of bitcoin#19250. The global `HasWallets()` is used only once and at the call site there's already a way to know if any wallet is loaded. ACKs for top commit: MarcoFalke: ACK ccf1f6e hebasto: ACK ccf1f6e, I have reviewed the changes and they look OK, I agree they can be merged. Tree-SHA512: fb902c045cbd331eaf71716c04734520f2ce7f2b317db510c4ce140162bbc683327b5a40ac860f6cde5add37e069065274d39dfa147fac2091eedec505f2f7eb
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 29, 2021
Summary: > Minor follow-up of [[bitcoin/bitcoin#19250 | core#19250]]. The global HasWallets() is used only once and at the call site there's already a way to know if any wallet is loaded. This is a backport of [[bitcoin/bitcoin#19261 | core#19261]] Depends on D9456 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D9457
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor follow-up of #19250. The global
HasWallets()is used only once and at the call site there's already a way to know if any wallet is loaded.