Add NATIVE_WINDOWS #1940
Merged
Add NATIVE_WINDOWS #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a change of libs, and specifying NATIVE_WINDOWS as TARGET_OS it should compile libleveldb.a and libmemenv.a just fine, it did for me and Diapolo when testing.
|
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/46936f343c5f9740e1ad8e0defeced7861c1a35a for binaries and test log. This could happen for one of several reasons:
|
|
It would be nice if the one, who did the Windows port could comment. Problem is I dunno, who it was... |
|
It would be even nicer, if that Boost stuff could be auto-detected, but I dunno how that could be achieved here. At least the uses version stuff here should match that from bitcoin-qt.pro, so I propose https://github.com/bitcoin/bitcoin/blob/master/bitcoin-qt.pro#L320 That patch is clearly for users building LevelDB directly on Windows, which currently doesn't work with Qt Creator as (for MinGW) you need to build LevelDB separately via the MinGW shell. |
|
Or even nicer if the Windows port didn't depend on boost... |
|
Diapolo, i tried to make it like the https://github.com/bitcoin/bitcoin/blob/master/src/makefile.mingw#L18 |
|
Merging on the assumption "better behavior than we had before" |
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Add NATIVE_WINDOWS
KolbyML
pushed a commit
to KolbyML/bitcoin
that referenced
this pull request
Dec 5, 2020
…ork connection and validations. a3c4d2d New constant MAX_STANDARD_SHIELDED_TX_SIZE defined for sapling txes standard-ness checks inside IsStandardTx. (furszy) 31a8fed TransactionBuilder: Do not set the binding signature if there is no shielded spends/outs. (furszy) ef47c57 Validation: Connecting Sapling ContextualCheckTransaction. (furszy) bfa4db4 Sapling transaction fixed fee check. (furszy) ef6c419 Add HaveShieldedRequirements checks in mempool, connectBlock and checkTxInputs (furszy) 880d289 validation: sapling merkle tree and view state update connection. (furszy) d6bcb06 Sapling CheckTransaction connection. (furszy) 74cbe90 Sapling validation, CheckTransaction implemented. (furszy) 89a469f Solver return false for empty scripts. (furszy) Pull request description: Hopefully the last decouple from bitcoin#1798. Focused on introducing network flow connection and validations for shielded transactions (primitives and contextual checks), coins cache nullifier and anchor and a test case covering the invalid paths. This work can be verified running 1798 functional tests suite. `sapling_wallet_nullifiers.py`, `sapling_wallet.py`, `sapling_wallet_anchorfork.py` , `sapling_key_import_export.py` are all running on top of this work, creating shielded txs, checking balances and generating blocks. -- A future to do in the area is the mempool validations (nullifiers) connection (stated in 1798 but a little bit of redundancy here doesn't hurt) and continue adding more test coverage for the validation area. Plus, discuss the fee topic further on its own PR, can be dynamic and not fixed as is now. -- #### Commits coming from 1798: * PR decoupled from 1798, focused on introducing Sapling transaction network validations. * TransactionBuilder: Do not set the binding signature if there is no shielded spends/outs. —> 096b0ed * Validation: Connecting Sapling ContextualCheckTransaction. —> b37998c * Sapling transaction fixed fee check. —> cda336e * Add HaveShieldedRequirements checks in mempool, connectBlock and checkTxInputs —> 3dbd319 * validation: sapling merkle tree and view state update connection. —> 382a99b * Sapling CheckTransaction connection. —> 3b40c6e * Sapling validation, CheckTransaction implemented. —> 7fd17ee * Solver return false for empty scripts. —> 3622a0d ACKs for top commit: random-zebra: re-utACK a3c4d2d Fuzzbawls: utACK a3c4d2d Tree-SHA512: 000127b623f3f1383fc1996cb811ba0e977ad6b2ada3fe8da80e2cbe685884aa7708ad906165c916e86f5d1a3676a54d6b1a0f44f9613a2ab1dfaace170f6fd3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a change of libs, and specifying NATIVE_WINDOWS as TARGET_OS it should compile libleveldb.a and libmemenv.a just fine, it did for me and Diapolo when testing.