Skip to content

Add HTTP REST, wget(1)-friendly crypted key dump via GET /wallet-ckeys.json #1982

Closed
wants to merge 1 commit into from

4 participants

@jgarzik
Bitcoin member
jgarzik commented Nov 4, 2012

See individual commits. This provides a slightly different, not-JSON-RPC API endpoint, which makes this HTTP request usable via "wget" and similar utilities.

The content returned and format thereof is certainly open to discussion.

My main goals were

  • fix HTTP request line parsing bugs
  • tighten HTTP request line validation, including "/" URI (our default JSON-RPC endpoint)
  • permit dump of crypted keys, without decrypting them
  • demonstrate a not-JSON-RPC API download endpoint
@sipa
Bitcoin member
sipa commented Nov 5, 2012

I like the idea of exposing certain data via HTTP instead of as RPC calls. Need to think about the format, though.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/83dd3f31e230ce8b8cc50026454f5e9b9a2b36a6 for binaries and test log.

@gavinandresen
Bitcoin member

OK on the first two commits. What is the use case for dumping crypted wallet keys?

@jgarzik jgarzik pushed a commit that referenced this pull request Nov 9, 2012
Jeff Garzik Merge branch 'http-improvements'
The base bits of pull req #1982.
8146591
@jgarzik
Bitcoin member
jgarzik commented Nov 16, 2012

Rebased.

@gavinandresen wallet backup, that doesn't need to be encrypted yet again. @sipa has a fair point on format, though.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0a60c82ad6f6acdd899825a5db65b2b1d2f7d841 for binaries and test log.

@jgarzik
Bitcoin member
jgarzik commented Apr 8, 2013

Closing. Not much interest, and wallet dump format still an open question.

Was originally at @kjj request.

@jgarzik jgarzik closed this Apr 8, 2013
@jgarzik jgarzik pushed a commit to jgarzik/bitcoin that referenced this pull request May 1, 2013
Jeff Garzik RPC: strictly require HTTP URI "/"
Previously, JSON-RPC clients accessed URI "/", and the JSON-RPC server
did not care about the URI at all, and would accept any URI as valid.

Change the JSON-RPC server to require URI "/" for all current accesses.

This changes enables the addition of future interfaces at different
URIs, such as pull request #1982 which demonstrates HTTP REST wallet
download.

Or, a future, breaking change in JSON-RPC interface could be introduced
by serving JSON-RPC calls from new URI "/v2/".
9f4976a
@laudney laudney pushed a commit to reddcoin-project/reddcoin that referenced this pull request Mar 19, 2014
Jeff Garzik Merge branch 'http-improvements'
The base bits of pull req #1982.
5f04022
@laudney laudney pushed a commit to reddcoin-project/reddcoin that referenced this pull request Mar 19, 2014
Jeff Garzik RPC: strictly require HTTP URI "/"
Previously, JSON-RPC clients accessed URI "/", and the JSON-RPC server
did not care about the URI at all, and would accept any URI as valid.

Change the JSON-RPC server to require URI "/" for all current accesses.

This changes enables the addition of future interfaces at different
URIs, such as pull request #1982 which demonstrates HTTP REST wallet
download.

Or, a future, breaking change in JSON-RPC interface could be introduced
by serving JSON-RPC calls from new URI "/v2/".
d5307d3
@jgarzik jgarzik deleted the jgarzik:http-backup branch Aug 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.