Add HTTP REST, wget(1)-friendly crypted key dump via GET /wallet-ckeys.json #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of exposing certain data via HTTP instead of as RPC calls. Need to think about the format, though. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/83dd3f31e230ce8b8cc50026454f5e9b9a2b36a6 for binaries and test log. |
|
OK on the first two commits. What is the use case for dumping crypted wallet keys? |
jgarzik
pushed a commit
that referenced
this pull request
Nov 9, 2012
The base bits of pull req #1982.
|
Rebased. @gavinandresen wallet backup, that doesn't need to be encrypted yet again. @sipa has a fair point on format, though. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0a60c82ad6f6acdd899825a5db65b2b1d2f7d841 for binaries and test log. |
|
Closing. Not much interest, and wallet dump format still an open question. Was originally at @KJJ request. |
jgarzik
pushed a commit
to jgarzik/bitcoin
that referenced
this pull request
May 1, 2013
Previously, JSON-RPC clients accessed URI "/", and the JSON-RPC server did not care about the URI at all, and would accept any URI as valid. Change the JSON-RPC server to require URI "/" for all current accesses. This changes enables the addition of future interfaces at different URIs, such as pull request bitcoin#1982 which demonstrates HTTP REST wallet download. Or, a future, breaking change in JSON-RPC interface could be introduced by serving JSON-RPC calls from new URI "/v2/".
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
The base bits of pull req bitcoin#1982.
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Previously, JSON-RPC clients accessed URI "/", and the JSON-RPC server did not care about the URI at all, and would accept any URI as valid. Change the JSON-RPC server to require URI "/" for all current accesses. This changes enables the addition of future interfaces at different URIs, such as pull request bitcoin#1982 which demonstrates HTTP REST wallet download. Or, a future, breaking change in JSON-RPC interface could be introduced by serving JSON-RPC calls from new URI "/v2/".
KolbyML
pushed a commit
to KolbyML/bitcoin
that referenced
this pull request
Dec 5, 2020
ab9c8d0 [RPC] Add totalsupply/moneysupply to getsupplyinfo/getinfo (random-zebra) cea10c7 [RPC][Cleanup] Remove zPIVsupply/zerocoinbalance from getinfo (random-zebra) c764f02 [RPC] Add shieldedsupply to getsupplyinfo and getinfo (random-zebra) Pull request description: Add the shielded pool value (at the chain tip) to `getsupplyinfo`/`getinfo` output. Rename `moneysupply` --> `transparentsupply` Remove `zPIVsupply`/`zerocoinbalance` from `getinfo` output. Based on top of: - [x] bitcoin#1983 ACKs for top commit: furszy: ACK ab9c8d0. Tree-SHA512: 62bda77195f8ae4c26efe4da417e850790c522ec3ccde39cc6f13ea4448947d4b1321b31201da8813923aa87640283cd913e40c3f45cce4dd8565ff8aae8924b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. This provides a slightly different, not-JSON-RPC API endpoint, which makes this HTTP request usable via "wget" and similar utilities.
The content returned and format thereof is certainly open to discussion.
My main goals were