Change 'make' to $(MAKE) in leveldb make command line #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/978770b59da4665f8cafc0083487e3c0696c45cc for binaries and test log. |
sipa
added a commit
that referenced
this pull request
Nov 27, 2012
Change 'make' to $(MAKE) in leveldb make command line
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Change 'make' to $(MAKE) in leveldb make command line
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Mar 21, 2018
Should fail for empty lock request
KolbyML
pushed a commit
to KolbyML/bitcoin
that referenced
this pull request
Dec 5, 2020
d0a324d Refactor: introduce IsAvailableState (to not call GetActiveState twice) (random-zebra) a8404a4 Refactor: remove CMasternode::Check - return "live" activeState. (random-zebra) Pull request description: This is the second part of bitcoin#2000 , and it's based on top of it. Here we remove `CMasternode::check()` and `CMasternode::activeState`, replacing it with a function `GetActiveState()`, which returns the state in real time. ACKs for top commit: furszy: nice work ☕, looking great, ACK d0a324d Fuzzbawls: utACK d0a324d Tree-SHA512: c0fa1d8ca13c4b21457990239198858426384a0578b1a6670912eb72e5f6b90c236c14d9eb6bbb6000ff401e1d512be692d72f873224d4c010d08a7df23f8f2e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other operating systems, like FreeBSD, have their own make programs, with different syntax. These install GNU make as gmake, and relay on the $(MAKE) macro to specify the right program.
The src/makefile.* files hard code make command line for leveldb, causing FreeBSD to use the wrong make command.
This pull edits this command to use the $(MAKE) macro, so the right make command is used.