Follow-up extra comments on taproot code and tests #20207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a few more things to address @MarcoFalke's review comments #19953 (review). |
maflcko
reviewed
Oct 21, 2020
There was a problem hiding this comment.
ACK
Couldn't find the doc comment change for #19953 (comment) though
sipa
force-pushed
the
202010_taproot-comments
branch
from
aed5aca
to
029d2d9
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
ACK 029d2d9 only changes comments and tests |
|
@ariard Mind to re-ACK? |
sipa
force-pushed
the
202010_taproot-comments
branch
from
029d2d9
to
402a502
Compare
|
re-ACK 4f10965 |
jonatack
reviewed
Nov 2, 2020
|
ACK 4f10965 |
sipa
force-pushed
the
202010_taproot-comments
branch
from
4f10965
to
4b8720f
Compare
sipa
force-pushed
the
202010_taproot-comments
branch
from
4b8720f
to
0efa4da
Compare
|
Rebased. |
|
|
|
@jonatack Thanks for catching that, fixed. |
sipa
force-pushed
the
202010_taproot-comments
branch
from
0efa4da
to
2d8099c
Compare
|
ACK 2d8099c per |
|
ACK 2d8099c, only changes are comment light improvements on IsValid/IsWitnessStandard. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 1, 2020
2d8099c Mention units of MAX_STANDARD_ policy constants (Pieter Wuille) 84e29c7 Mention in validation that IsWitnessStandard tests for P2TR (Pieter Wuille) f867cbc Clean up assets test minimizer LDFLAGS (Pieter Wuille) ea0e786 Document additional IsWitnessStandard behavior (Pieter Wuille) 6040de9 Add comments on CPubKey::IsValid (Pieter Wuille) 8dbb7de Add comments to VerifyTaprootCommitment (Pieter Wuille) cdf900c Document need_vin_vout_mismatch argument to make_spender (Pieter Wuille) 18246ed Fix and improve taproot_construct comments (Pieter Wuille) Pull request description: Addressing some review comments raised here: bitcoin#19953 (review) and bitcoin#19953 (review) ACKs for top commit: jonatack: ACK 2d8099c per `git range-diff 5009159 4f10965 2d8099c` ariard: ACK 2d8099c, only changes are comment light improvements on IsValid/IsWitnessStandard. Tree-SHA512: c4881546c379ea8efc7ef99a43cbf3b9cd3f9dde5fd97a07ee66f2b593c78aef0bd8784853c5c9c737b66c269241a1048bbbdd6c964a3d872efd8ba0ec410b68
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing some review comments raised here: #19953 (review) and #19953 (review)