-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reformat OS X build instrcs, add 10.8 + Homebrew #2026
reformat OS X build instrcs, add 10.8 + Homebrew #2026
Conversation
should be put, or just try the below command. | ||
|
||
echo "rpcuser=bitcoinrpc | ||
rpcpassword=HdAseQSRkirfoNuUSzqzixyL9sM1T6ABfzV1nyNmbuwg" > "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rpcpassword=$(xxd -l 16 -p /dev/urandom) > ...etc would be better to create a random 16-hex-character password.
Updated as suggested! |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/933304fe886c8e7f3dd6d90acec3f8ee7cd60980 for binaries and test log. |
Question: why is openssl special with homebrew? It'd be really nice not to have to ship a Makefile.osx patch that is likely to break when we change Makefile.osx in the future, and it looks like openssl is the only change that couldn't just be made to Makefile.osx directly. Also: I think breaking the instructions into three sections:
... would be less confusing. Finally: can you squash all this into one commit? |
Homebrew doesn't link openssl like it does other packages because "The OpenSSL provided by OS X is too old for some software." It installs in "keg-only" mode, and has to be manually linked only if required:
I interpret this to mean that if we rely on openssl to be linked already or include an instruction to link it, things may break. I'd rather not see Bitcoin as the cause of a broken dev system because a newer version of openssl is causing problems for Apple's stuff. One can get the path to Homebrew's installation of openssl with This also exacerbates static building, because it, too, relies on That said, I'd rather not see a separate makefile.osx just for Homebrew folk. The patch does just enough to make it work for now. I could further improve the patch and the instructions to allow passing of If we* could alter Unfortunately, I don't have access to a system with MacPorts installed and I'm hesitant to introduce it onto mine for fear of messing up my own environment for other things ;-) If what's here now in this pull request is good enough for 0.8, I'll split the HOWTO into sections as suggested and squash these commits somehow (is there a way to do that without having to delete and recreate the branch? I've only had to squash once and just ended up doing that and resubmitting a PR) and get them ready. Otherwise, perhaps a *we = someone involved in the project with perhaps stronger Makefile kung-foo than I |
I note also that I'll need to remove the |
I just set up a machine to do a release build a couple of days ago for the 0.7.2 release, so I went through my bash history and updated the instructions: |
I've not forgotten about this. I intend to get to it mid week. |
I've incorporated the suggested changes and squashed everything together. |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/82cc0ea4fb3e6847ba7475d4fa28942132009de4 for binaries and test log. |
Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/82cc0ea4fb3e6847ba7475d4fa28942132009de4 for test log. This pull does not merge cleanly onto current master |
@colindean, rebase needed |
@luke-jr I think I did it right...? |
I updated my branch to ensure that it merges cleanly with master. |
I just updated again, resyncing with master and with two optimizations:
The makefile patch is still necessary. A future optimization would ideally remove this necessity, but I don't have another machine available running MacPorts on which I can test. |
Another update, after discovering a new formula in Homebrew for building berkeley-db4 without having to revert to an older version of the formula. Revised the makefile patch and the instructions to reflect this. Now, the only existing difference between the Homebrew and MacPorts instructions is the need to patch the makefile because of path differences between the two systems. |
* reformatted the entire document to look pretty in both standard text and Markdown * incorporated [my OS X 10.8 build instructions with Homebrew as the package manager](http://bitcoin.stackexchange.com/questions/3672/trouble-compiling-bitcoind-on-osx-with-homebrew/5253#5253) * incorporated @gavinandresen's MacPorts and release build instructions based on an earlier revision of this commit * added makefile patch necessary for Homebrew compilation to `contrib`
Rebased to current master as of 0.8.0 release. @gavinandresen @luke-jr, anything else? |
…nstructions reformat OS X build instrcs, add 10.8 + Homebrew
…e-osx-instructions reformat OS X build instrcs, add 10.8 + Homebrew
578e308 [Cleanup] Remove stale siphash.py file (Fuzzbawls) Pull request description: This file managed to get reintroduced after we moved the regression test suite to the `test` folder. Remove it as it isn't used anywhere. ACKs for top commit: random-zebra: Yeah, the one we use is the `test` folder. utACK 578e308 furszy: utACK 578e308 Tree-SHA512: 5a96e8b9086ce6ecea7a5e20416a6021e59c756144f98a34160fa8d1d7da2b0ed97df1ab3fad67d281e02bdcd3cd282dd01190a24ebff14fcac354fae4b58560
I reformatted the entire document to look pretty in both standard text and Markdown. This should make it a lot easier to read.
Also, I incorporated my OS X 10.8 build instructions with Homebrew as the package manager. I originally posted them on the Bitcoin Stackexchange in the question Trouble compiling bitcoind on OSX with homebrew. I've used these instructions twice now, so I'm fairly certain they'll work.
I do recognize that I need to find a way to get the Makefile to look at Homebrew's Cellar without needing to be patched. WIP on my branch entitled feature/osx10.8-bitcoind-compilation.