Fix duplicate shortcut usage in sign/verify message dialog. #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ecd67a142066ba7e5e2a92d152cb8bfb156d6f69 for binaries and test log. |
|
Will this fix still work after all the commits done lately? |
|
Yes, as there were no recent changes to signverifymessagedialog.ui this commit will merge just fine to current master. @laanwj Ping :) |
|
Can we get this merged please? |
|
This seems to change both sign and verify to alt-m ? |
|
@sipa Indeed, but they are on different tabs and each tab is reached by the now changed shortcut, so that we now have a shortcut to reach the tab and a shortcut to execute the sign or verify :). |
|
Tested: indeed, typing alt-m triggers the shortcut in the current tab |
laanwj
added a commit
that referenced
this pull request
Jan 1, 2013
Fix duplicate shortcut usage in sign/verify message dialog.
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Fix duplicate shortcut usage in sign/verify message dialog.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the duplicate shortcut usage in sign(alt+s)/verify(alt+v) message dialog.
Bug described in issue: #1927