RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC endpoint wallet #20448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
reviewed
Nov 21, 2020
|
That's what the current code does (and the first commit of this PR documents). |
|
would be easier to review and backport if the commit was a separate pull |
jonatack
reviewed
Nov 23, 2020
| @@ -355,12 +355,18 @@ def wallet_file(name): | |||
| assert_raises_rpc_error(-1, "JSON value is not a string as expected", self.nodes[0].unloadwallet) | |||
| assert_raises_rpc_error(-18, "Requested wallet does not exist or is not loaded", self.nodes[0].unloadwallet, "dummy") | |||
| assert_raises_rpc_error(-18, "Requested wallet does not exist or is not loaded", node.get_wallet_rpc("dummy").unloadwallet) | |||
| assert_raises_rpc_error(-8, "Cannot unload the requested wallet", w1.unloadwallet, "w2"), | |||
| assert_raises_rpc_error(-8, "RPC request wallet and wallet_name parameter specify different wallets", w1.unloadwallet, "w2"), | |||
There was a problem hiding this comment.
81162ec For the first commit, suggest testing with the same wallet name:
- assert_raises_rpc_error(-8, "Both the RPC request wallet and wallet_name parameter were provided (only one allowed)", w1.unloadwallet, "w2"),
+ assert_raises_rpc_error(-8, "Both the RPC request wallet and wallet_name parameter were provided (only one allowed)", w1.unloadwallet, w1.getwalletinfo()["walletname"]),
|
@MarcoFalke Should I interpret that as a NACK to backporting the 2nd commit? (I said at least the first...) |
|
Yes, feature freeze was a month ago |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
maflcko
pushed a commit
that referenced
this pull request
Nov 24, 2020
…the RPC request and wallet_name parameter specify a wallet b1f59d5 RPC/Wallet: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet (Luke Dashjr) Pull request description: Just documentation clarifications from #20448 ACKs for top commit: MarcoFalke: review ACK b1f59d5 jonatack: re-ACK b1f59d5 per `git diff e8303a0 b1f59d5` Tree-SHA512: ac068b0aa7ceed49496367fdd9425b59dbba18b56e89b26afc22a6c8ece51f0b92a169cacd55740b1cadab2b32f4f8e8700e609066ab7e59d3b53c7891da585e
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 24, 2020
…n both the RPC request and wallet_name parameter specify a wallet b1f59d5 RPC/Wallet: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet (Luke Dashjr) Pull request description: Just documentation clarifications from bitcoin#20448 ACKs for top commit: MarcoFalke: review ACK b1f59d5 jonatack: re-ACK b1f59d5 per `git diff e8303a0 b1f59d5` Tree-SHA512: ac068b0aa7ceed49496367fdd9425b59dbba18b56e89b26afc22a6c8ece51f0b92a169cacd55740b1cadab2b32f4f8e8700e609066ab7e59d3b53c7891da585e
luke-jr
force-pushed
the
unloadwallet_namematch
branch
from
2e9ada5
to
89bdad5
Compare
luke-jr
changed the title
luke-jr
changed the title
|
rebased |
|
ACK 89bdad5 |
|
review ACK 89bdad5 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 28, 2020
…t_name param matching RPC endpoint wallet 89bdad5 RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC endpoint (Luke Dashjr) Pull request description: Allow specifying the `wallet_name` param to `unloadwallet` on RPC wallet endpoints, so long as it matches the endpoint wallet. ACKs for top commit: jonatack: ACK 89bdad5 MarcoFalke: review ACK 89bdad5 Tree-SHA512: efb399c33f7b5596870a26a8680f453ca47aa7a6db4e550f9435d13044f1c4bad0ae11e8f0205213409d08b75c4188c3be782e54aafab1f65b97eb8cf5c252a9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying the
wallet_nameparam tounloadwalleton RPC wallet endpoints, so long as it matches the endpoint wallet.