New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: warn when generating man pages for binaries built from a dirty branch #20468
Conversation
Just noticed the failing checks. On mobile, not sure how to mark as in progress, will investigate. |
Thank you! Need to test this but changes look good to me at first sight. Implementing |
Travis failure is boring (due to trailing whitespace)
|
fixed linting issues, we should be good to go now. thanks! |
Concept NACK. No reason manpages shouldn't generate for any given checkout... Maybe making sure the binaries match the current Perhaps CI checks? |
@luke-jr ci checks would be good. How does everyone feel about a warning/notification echoed out instead of returning early? The warning to prevent accidental check-ins + the CI checks should get the desired effect while allowing man page generation at any point. |
A warning sounds fine to me too. |
@luke-jr The problem is accidentally checking in manual pages with a (I mean, the non-determinism implied by generating the pages from a state of the tree that was never checked in in the first place, isn't that wrong by default?) |
CI checks are way too late. And I don't really want to do anything complicated with git check-in hooks either. This script seems to be the best place to ensure it. But sure, I'm okay with adding a way to bypass the check if you really want to. For say, testing the script it could make sense. |
@laanwj The runtime warning from gen-manpages would hopefully be enough to alert the user not to commit it? |
Adjusted version flag behavior in bitcoin-tx, bitcoin-wallet, and bitcoind to match. Added functionality in gen-manpages.sh to warning when attempting to generate man pages for binaries built from a dirty branch.
updated to warn instead of outright fail, which should solve some of the problem in the original issue while still providing flexibility, should one want to generate man pages for bins built from a dirty branch. |
Tested ACK 6690adb
Yea seems strong enough warning. |
|
I had a broken setup. Sorry for noise. |
--version
flag behavior in bitcoind and bitcoin-wallet to have the same behavior.--version
flag to bitcoin-tx to match.mitigates problem with issue #20412