Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .gitignore ignore src/test/fuzz/fuzz.exe #21336

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 2, 2021

No description provided.

@fanquake
Copy link
Member

fanquake commented Mar 2, 2021

Shouldn't this be included by *.exe ?

@hebasto
Copy link
Member Author

hebasto commented Mar 2, 2021

Shouldn't this be included by *.exe ?

Did not dig into the depth, but it does not work.

@laanwj
Copy link
Member

laanwj commented Mar 2, 2021

Strange, as we don't mention any of the other .exe explicitly. What's different about the fuzz one?

Edit: it's this rule:

!src/test/fuzz/*.*

Why do we need that?

@hebasto
Copy link
Member Author

hebasto commented Mar 2, 2021

Strange, as we don't mention any of the other .exe explicitly. What's different about the fuzz one?

Edit: it's this rule:

!src/test/fuzz/*.*

Right.

@laanwj
Copy link
Member

laanwj commented Mar 2, 2021

Would it work to move that rule above the *..exe one?

@hebasto
Copy link
Member Author

hebasto commented Mar 2, 2021

Edit: it's this rule:

!src/test/fuzz/*.*

Why do we need that?

Appears that we do not need it :)

Also s/src/test/fuzz/*/src/test/fuzz/fuzz/ to be explicit.

@hebasto hebasto changed the title Add src/test/fuzz/fuzz.exe to .gitignore Make .gitignore ignore src/test/fuzz/fuzz.exe Mar 2, 2021
@practicalswift
Copy link
Contributor

Concept ACK

@maflcko
Copy link
Member

maflcko commented Mar 2, 2021

cr ACK 35da623

1 similar comment
@practicalswift
Copy link
Contributor

cr ACK 35da623

@fanquake fanquake merged commit 0459e7a into bitcoin:master Mar 3, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Mar 3, 2021
@hebasto hebasto deleted the 210302-ignore branch March 3, 2021 06:30
@laanwj
Copy link
Member

laanwj commented Mar 5, 2021

Posthumous ACK, this is a much better solution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants