fuzz: Avoid -Wreturn-type warnings #21364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
approved these changes
Mar 4, 2021
| @@ -10,6 +10,7 @@ | |||
| #include <attributes.h> | |||
| #include <chainparamsbase.h> | |||
| #include <coins.h> | |||
| #include <compat.h> | |||
There was a problem hiding this comment.
nit: I am not really a fan of turning this into a "include all headers that exist" file. This could be a separate module, but as a start, what about moving the implementation details to the cpp file at least?
There was a problem hiding this comment.
I agree, but note that compat.h was already transitively included via at least four other already included files (net.h, netaddress.h, netbase.h and util/time.h).
Thus the explicit inclusion doesn't change anything in practice from a technical perspective: it only makes it clear that we depend on compat.h :)
Explicit is better than implicit as we all know by now :)
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 5, 2021
3f36468 fuzz: Avoid -Wreturn-type warnings (practicalswift) Pull request description: Avoid `-Wreturn-type` warnings. Closes bitcoin#21355. ACKs for top commit: MarcoFalke: cr ACK 3f36468 fanquake: ACK 3f36468 - thanks for cleaning this up. Tree-SHA512: 6fa2640a26e64d2bea60e016ad14b5c434137fedc0b3bf2ac244f02f9b1cd303d1ebac4ac4e6791534560f8311c4cbe9395c2ce94d7ec022d3b192f1ea070809
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
-Wreturn-typewarnings.Closes #21355.