Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: remove scantxoutset EXPERIMENTAL warning #21426

Merged
merged 1 commit into from
Mar 15, 2021
Merged

rpc: remove scantxoutset EXPERIMENTAL warning #21426

merged 1 commit into from
Mar 15, 2021

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented Mar 12, 2021 •
edited
Loading

Remove old warning per IRC wallet meeting discussion at http://www.erisian.com.au/bitcoin-core-dev/log-2021-03-12.html#l-467

This RPC was merged 3 years ago in #12196.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ghost
ghost approved these changes Mar 13, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4793007

Someone had asked me this IRL recently and I had suggested to use it as long as it is helpful. I think this is the only RPC which can be used to get UTXO details if the address doesn't belong to wallet(without importing).

@DrahtBot DrahtBot mentioned this pull request Mar 13, 2021
Merged
@fjahr
Copy link
Contributor

fjahr commented Mar 14, 2021 •
edited
Loading

ACK 4793007

@maflcko
Copy link
Member

maflcko commented Mar 15, 2021

This RPC was merged 3 years ago in #12196.

Just for completeness, the interface was broken to be descriptors-only some time after that.

Concept ACK.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@sipa
Copy link
Member

sipa commented Mar 15, 2021

@MarcoFalke The pre-descriptors version was never released AFAIK.

@maflcko
Copy link
Member

maflcko commented Mar 15, 2021

Indeed. Both are in 0.17.0 (commit 151600b)

@jonatack
Copy link
Contributor Author

rebased

@maflcko
Copy link
Member

maflcko commented Mar 15, 2021

cr ACK 2f0b25a

jonasschnelli
jonasschnelli approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2f0b25a

@maflcko maflcko merged commit c479797 into bitcoin:master Mar 15, 2021
@jonatack jonatack deleted the rm-scantxoutset-warning branch March 15, 2021 10:32
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 15, 2021
Merge bitcoin#21426: rpc: remove scantxoutset EXPERIMENTAL warning
1bd24c7 
2f0b25a rpc: remove scantxoutset EXPERIMENTAL warning (Jon Atack)

Pull request description:

  Remove old warning per IRC wallet meeting discussion at http://www.erisian.com.au/bitcoin-core-dev/log-2021-03-12.html#l-467

  This RPC was merged 3 years ago in bitcoin#12196.

ACKs for top commit:
  MarcoFalke:
    cr ACK 2f0b25a

Tree-SHA512: 874ccd5bd19ecbbe91912171ac85af7a4658dc92f6db484ff3d03f07f1b9ba97e1c69d33a5c3ae5c5ec46cac3595a211f55fec0fbf81bac30d66a891c376ce26
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Apr 13, 2022
@jonatack @PiRK
rpc: remove scantxoutset EXPERIMENTAL warning
022b780 
Summary:
Also remove an unnecessary leading "\n" (see D7184)

This is a backport of [[bitcoin/bitcoin#21426 | core#21426]]

Test Plan: `src/bitcoin-cli help scantxoutset`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11338
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jonatack @DrahtBot @fjahr @maflcko @sipa @jonasschnelli @fanquake