test: make sure non-IP peers get discouraged and disconnected (vasild) #21571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This is a non-functional change that replaces the `CNode` on-stack variables with `CNode` pointers. The reason for this is that it would allow us to add those `CNode`s to `CConnman::vNodes[]` which in turn would allow us to check that they are disconnected properly - a `CNode` object must be in `CConnman::vNodes[]` in order for its `fDisconnect` flag to be set. If we store pointers to the on-stack variables in `CConnman` then it would crash at the end, trying to `delete` them.
Use `CConnmanTest` instead of `CConnman` and add the nodes to it so that their `fDisconnect` flag is set during disconnection.
maflcko
force-pushed
the
2104-testPointers
branch
from
3d5eac6
to
81747b2
Compare
|
ACK 81747b2 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 6, 2021
This is a non-functional change that replaces the `CNode` on-stack variables with `CNode` pointers. The reason for this is that it would allow us to add those `CNode`s to `CConnman::vNodes[]` which in turn would allow us to check that they are disconnected properly - a `CNode` object must be in `CConnman::vNodes[]` in order for its `fDisconnect` flag to be set. If we store pointers to the on-stack variables in `CConnman` then it would crash at the end, trying to `delete` them. Github-Pull: bitcoin#21571 Rebased-From: 4d6e246
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 6, 2021
Use `CConnmanTest` instead of `CConnman` and add the nodes to it so that their `fDisconnect` flag is set during disconnection. Github-Pull: bitcoin#21571 Rebased-From: 637bb6d
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 6, 2021
Github-Pull: bitcoin#21571 Rebased-From: 81747b2
|
Backported in #21614 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 6, 2021
… disconnected (vasild) 81747b2 test: make sure non-IP peers get discouraged and disconnected (Vasil Dimov) 637bb6d test: also check disconnect in denialofservice_tests/peer_discouragement (Vasil Dimov) 4d6e246 test: use pointers in denialofservice_tests/peer_discouragement (Vasil Dimov) Pull request description: Split up from bitcoin#20966, so that it can be backported easier. Merging this ahead of bitcoin#20966 will also reduce the number of conflicts for that pull. ACKs for top commit: jonatack: ACK 81747b2 Tree-SHA512: 8f0e30b95baba7f056920d7fc3b37bd49ee13e69392fe80e2d333c6bb09fd25f4603249301b8795cca26a2f2d15b9f8904798a55cd9c04fd28afb316e95c551c
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 16, 2021
This is a non-functional change that replaces the `CNode` on-stack variables with `CNode` pointers. The reason for this is that it would allow us to add those `CNode`s to `CConnman::vNodes[]` which in turn would allow us to check that they are disconnected properly - a `CNode` object must be in `CConnman::vNodes[]` in order for its `fDisconnect` flag to be set. If we store pointers to the on-stack variables in `CConnman` then it would crash at the end, trying to `delete` them. Github-Pull: bitcoin#21571 Rebased-From: 4d6e246
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 16, 2021
Use `CConnmanTest` instead of `CConnman` and add the nodes to it so that their `fDisconnect` flag is set during disconnection. Github-Pull: bitcoin#21571 Rebased-From: 637bb6d
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 16, 2021
Github-Pull: bitcoin#21571 Rebased-From: 81747b2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up from #20966, so that it can be backported easier. Merging this ahead of #20966 will also reduce the number of conflicts for that pull.