Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: produce Windows GUI build with Cirrus CI #21764

Closed
wants to merge 6 commits into from

Conversation

wu-emma
Copy link

@wu-emma wu-emma commented Apr 23, 2021

This PR is a build of Bitcoin Core for Windows with Cirrus CI. It creates executable files,
including bitcoin-qt.exe and packs them to NSIS installer .exe file.

It's built using MSVC toolchain with the solution files from build_msvc, so the
commands in the task are different than ones used in CI folder.

Please consider this as a prototype, if making builds from single CI system could
be counted as simpler approach. In such case I would make changes according to feedback and
some refactoring should still be required.

@fanquake fanquake added the Tests label Apr 23, 2021
@maflcko
Copy link
Member

maflcko commented Apr 23, 2021

How does this compare to #21551 ?

@wu-emma
Copy link
Author

wu-emma commented Apr 23, 2021

Sorry, I didn't noticed #21551 somehow. The main difference is producing of installer .exe file.

@laanwj
Copy link
Member

laanwj commented May 12, 2021

What is your reasoning behind creating a new kind of installer in the integration tests? I don't think this makes sense for us, to to add testing for the windows installer, it'd need to be built in the same way as the gitian distribution one.

@wu-emma
Copy link
Author

wu-emma commented May 13, 2021

We are using only Cirrus CI for experimental BTC-derived project Bitgesell and at the time didn't saw @hebasto 's PR, so decided to share the code for Bitcoin Core. Wondering why both AppVeyor and CirrusCI are used, like to have greater unification of auto testing and building. By the way, testing of windows install/uninstall looks like a great idea, would think about it.

@fanquake
Copy link
Member

Doesn't seem to be heaps of motivation here, lets start with #21551. Going to close this for now.

@fanquake fanquake closed this May 14, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants